Re: [PATCH v3] b4: support send-email aliases

[Jacob Keller <jacob.e.keller@intel.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1177 bytes --]



On 10/9/2025 1:21 PM, Konstantin Ryabitsev wrote:
> On Thu, Oct 09, 2025 at 12:49:07PM -0700, Jacob Keller wrote:
>>> This has the following benefits:
>>>
>>> 1. If the same alias is used in 20 patches, we're only looking it up once.
>>> 2. It'll be automatically used in the following block of code without needing
>>>    to modify the addresses list here.
>>>
>>
>> One other issue is that this means if you have an alias, it will not be
>> covered by mailmap.
>>
>> I'm wondering if what we want is a separate ALIAS_INFO instead?
> 
> Ah, hm, you're right.
> 
> Yes, go ahead and make a new global caching map. It's very unlikely to be
> more than a few entries large, so the impact should be minimal.
> 

Right. It should only ever really be the number of aliases + potentially
any unintentional unqualified addresses that aren't proper aliases. Its
not even the size of every alias in your aliases file since we only load
ones which get matched.

> Then we do want to run through the list twice:
> 1. first run replacing aliases (new loop)
> 2. second run checking against mailmap (existing loop)
> 
> -K

Yep, that's what I did in v4.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]