From: Dave Marquardt <davemarq@linux.ibm.com>
To: Konstantin Ryabitsev <mricon@kernel.org>
Cc: tools@kernel.org, Tyrel Datwyler <tyreld@linux.ibm.com>
Subject: Re: [Tyrel Datwyler] Re: [PATCH v2 6/7] ibmvfc: register and use asynchronous sub-queue
Date: Wed, 17 Jun 2026 17:10:26 -0500 [thread overview]
Message-ID: <87eci4yg19.fsf@linux.ibm.com> (raw)
In-Reply-To: <20260617-true-spiked-wallaby-4834ad@meerkat>
Konstantin Ryabitsev <mricon@kernel.org> writes:
> On Tue, Jun 16, 2026 at 07:52:36AM -0500, Dave Marquardt wrote:
>> > You can either manually run all commits with -s (which is what I do), or you
>> > can set up a hook to do that for you automatically -- but since it's supposed
>> > to be a deliberate action by the committer, I recommend just always
>> > remembering to add that little "-s" after "git commit".
>>
>> Thanks. I searched and searched the b4 documentation, and now, from your
>> explanation, understand why I don't see anything about Signed-off-by:
>> when submitting a patch series. Would it be worth adding something to
>> the manual? (Yes, if so, I'm volunteering :) )
>
> I don't think so. The Signed-off-by: is common, but not at all a requirement,
> and since enabling/adding it must be a deliberate and well-understood decision
> by the commit author, I don't think it belongs in b4.
>
> I know we can spell it out in the b4 docs, but I don't know if people are
> going to be more likely to read them as opposed to the actual kernel
> documentation.
Fair enough. Thanks.
-Dave
prev parent reply other threads:[~2026-06-17 22:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 21:14 [Tyrel Datwyler] Re: [PATCH v2 6/7] ibmvfc: register and use asynchronous sub-queue Dave Marquardt
2026-06-15 21:51 ` Konstantin Ryabitsev
2026-06-16 12:52 ` Dave Marquardt
2026-06-17 21:17 ` Konstantin Ryabitsev
2026-06-17 22:10 ` Dave Marquardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eci4yg19.fsf@linux.ibm.com \
--to=davemarq@linux.ibm.com \
--cc=mricon@kernel.org \
--cc=tools@kernel.org \
--cc=tyreld@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox