From: Kyle Meyer <kyle@kyleam.com>
To: tools@linux.kernel.org
Subject: Re: [PATCH b4] Delay dns.resolver.get_default_resolver call
Date: Wed, 21 Apr 2021 19:43:44 -0400 [thread overview]
Message-ID: <87fszji4pb.fsf@kyleam.com> (raw)
In-Reply-To: <20210208040722.31203-1-kyle@kyleam.com>
Kyle Meyer writes:
> When b4.attestation-policy is 'off', calling `b4 am` with
> --use-local-mbox is conceptually an offline operation, but it still
> requires being online because get_default_resolver() is called at the
> top-level of b4/__init__.py.
>
> Support offline operation by delaying the call to
> get_default_resolver() until it's needed. Note that
> get_default_resolver() already caches the result, so there's no need
> for b4 to store the result as a global variable on its end.
Any thoughts on this patch?
next prev parent reply other threads:[~2021-04-21 23:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 4:07 [PATCH b4] Delay dns.resolver.get_default_resolver call Kyle Meyer
2021-04-21 23:43 ` Kyle Meyer [this message]
2021-04-22 18:09 ` Konstantin Ryabitsev
2021-05-14 20:37 ` Konstantin Ryabitsev
2021-05-14 21:24 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fszji4pb.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox