tools.linux.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Marquardt <davemarq@linux.ibm.com>
To: tools@kernel.org, Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Subject: b4 send --resend broken by 8cae1088cf605a12ed3207e7743fadcfa95c252a
Date: Thu, 26 Jun 2025 10:03:40 -0500	[thread overview]
Message-ID: <87sejmk0j7.fsf@linux.ibm.com> (raw)

commit 8cae1088cf605a12ed3207e7743fadcfa95c252a
Author: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Date:   Mon Jun 9 17:09:43 2025 -0400

    Further mypy typing enhancements
    
    Continued work to get ourselves to mypy strict clean runs. This mostly
    focuses on ez.py, but also tweaks a few other files where typing info
    was incorrect.
    
    Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>

seems to have broken "b4 send --resend", which fails with

    CRITICAL: This is not a prep-managed branch or it was created by someone else.

The commit added a check for tag_msg after the else handling resend in cmd_send():

@@ -1802,12 +1873,16 @@ def cmd_send(cmdargs: argparse.Namespace) -> None:
 
         logger.info('Converted the branch to %s messages', len(patches))
 
+    if tag_msg is None:
+        logger.critical('CRITICAL: unable to get tag_msg from %s', mybranch)
+        sys.exit(1)
+

tag_msg isn't set in the resend path, so resend now fails.

-Dave

             reply	other threads:[~2025-06-26 15:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-26 15:03 Dave Marquardt [this message]
2025-06-26 17:21 ` b4 send --resend broken by 8cae1088cf605a12ed3207e7743fadcfa95c252a Konstantin Ryabitsev
2025-06-26 17:25 ` Bugspray Bot
2025-06-27 17:00 ` Bugspray Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sejmk0j7.fsf@linux.ibm.com \
    --to=davemarq@linux.ibm.com \
    --cc=konstantin@linuxfoundation.org \
    --cc=tools@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).