b4 send --resend broken by 8cae1088cf605a12ed3207e7743fadcfa95c252a

b4 send --resend broken by 8cae1088cf605a12ed3207e7743fadcfa95c252a

[Dave Marquardt]

commit 8cae1088cf605a12ed3207e7743fadcfa95c252a
Author: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Date:   Mon Jun 9 17:09:43 2025 -0400

    Further mypy typing enhancements
    
    Continued work to get ourselves to mypy strict clean runs. This mostly
    focuses on ez.py, but also tweaks a few other files where typing info
    was incorrect.
    
    Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>

seems to have broken "b4 send --resend", which fails with

    CRITICAL: This is not a prep-managed branch or it was created by someone else.

The commit added a check for tag_msg after the else handling resend in cmd_send():

@@ -1802,12 +1873,16 @@ def cmd_send(cmdargs: argparse.Namespace) -> None:
 
         logger.info('Converted the branch to %s messages', len(patches))
 
+    if tag_msg is None:
+        logger.critical('CRITICAL: unable to get tag_msg from %s', mybranch)
+        sys.exit(1)
+

tag_msg isn't set in the resend path, so resend now fails.

-Dave

Re: b4 send --resend broken by 8cae1088cf605a12ed3207e7743fadcfa95c252a

[Konstantin Ryabitsev]

On Thu, Jun 26, 2025 at 10:03:40AM -0500, Dave Marquardt wrote:
> tag_msg isn't set in the resend path, so resend now fails.

Thank you for the report.

bugspray tag me

Re: b4 send --resend broken by 8cae1088cf605a12ed3207e7743fadcfa95c252a

[Bugspray Bot]

Hello:

This conversation is now tracked by Kernel.org Bugzilla:
https://bugzilla.kernel.org/show_bug.cgi?id=220276

There is no need to do anything else, just keep talking.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: b4 send --resend broken by 8cae1088cf605a12ed3207e7743fadcfa95c252a

[Bugspray Bot]

Konstantin Ryabitsev writes in commit cff911a15f240d09032f90a85a000723e0baadd3:

ez: fix --resend

The tag_msg would only be defined if we're not doing resend, so move the
None check to where it makes sense.

Reported-by: Dave Marquardt <davemarq@linux.ibm.com>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220276
Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>

(via https://git.kernel.org/pub/scm/utils/b4/b4.git/commit/?id=cff911a15f24)
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)