Re: [PATCH b4 v2] ez: add subject prefix flag

[Andreas Hindborg <a.hindborg@kernel.org>]

"Konstantin Ryabitsev" <konstantin@linuxfoundation.org> writes:

> On Tue, Feb 04, 2025 at 04:30:45PM +0100, Andreas Hindborg wrote:
>> Add a flag `-p PREFIX`/`--add-subject-prefix=PREFIX` to `am` and `shazam`
>> commands. This flag will add PREFIX to the subject line of each patch before
>> applying the patch.
>>
>> One use case for this is when composing trees that consist of patches from many
>> different sources. Adding a prefix to the subject of each series makes it easy
>> to see the origin when scanning the commit log.
>
> I get the reason why you would want this, but I also kinda hate the idea,
> because I'm almost 100% sure that this will make it into someone's -next tree
> or something like that.
>
> Can we take a step back and try to look at it from a broader perspective? Do
> you use this approach during code review, or for some other purpose?

I use it when assembling trees for upstream work. For instance see [1].
It is super valuable for me to know what commits are from list when
scanning down the git log.

For a series prepared with b4 it looks something like this:

f3d69aaf6b6c1 * configfs MAINTAINERS: add entry for configfs Rust abstractions
b813426cf1e74 * rust: configfs: introduce rust support for configfs
d2a88d97552a9 * rust: sync: change `<Arc<T> as ForeignOwnable>::PointedTo` to `T`
935d4487ff8d5 * rust: configfs abstractions
0a2d72888abc3 * LIST: [PATCH v15 1/3] rust: types: add `ForeignOwnable::PointedTo`
988bd1ba2ebb3 * LIST: [PATCH 3/3] kbuild: rust: support `W=e` for Rust
3b39f5625406b * LIST: [PATCH 2/3] kbuild: rust: apply `CONFIG_WERROR` to all Rust targets
89cfa7f9c1099 * LIST: [PATCH 1/3] kbuild: rust: move `-Dwarnings` handling to `Makefile.extrawarn`
2014c95afecee * v6.14-rc1 torvalds/master local/torvalds/master Linux 6.14-rc1

Here commit HEAD~3 is a b4 cover letter.

I'm not married to this approach, it was just the only one I could
think of. I really like that the patches I apply with `b4 shazam ..`
appear with `LIST: [PATCH vX X/Y] ..`.


Best regards,
Andreas Hindborg


[1] https://git.kernel.org/pub/scm/linux/kernel/git/a.hindborg/linux.git/log/?h=rnull-v6.14-rc1