Re: [PATCH RESEND v2] Make edit_in_editor use temporary file in Git repository

[Dave Marquardt <davemarq@linux.ibm.com>]

Konstantin Ryabitsev <konstantin@linuxfoundation.org> writes:

> On Tue, 18 Nov 2025 15:34:25 -0600, Dave Marquardt <davemarq@linux.ibm.com> wrote:
>> diff --git a/src/b4/__init__.py b/src/b4/__init__.py
>> index 7689550..cc7623a 100644
>> --- a/src/b4/__init__.py
>> +++ b/src/b4/__init__.py
>> @@ -4575,8 +4575,16 @@ def edit_in_editor(bdata: bytes, filehint: str = 'COMMIT_EDITMSG') -> bytes:
>>      corecfg = get_config_from_git(r'core\..*', {'editor': os.environ.get('EDITOR', 'vi')})
>>      editor = corecfg.get('editor')
>>      logger.debug('editor=%s', editor)
>> +
>> +    topdir = git_get_toplevel()
>> +    if topdir is not None:
>> +        p = Path(topdir)
>> +        p = p / '.git' / 'b4'
>
> Hardcoding `.git` will break when b4 is run inside a git worktree,
> where `.git` is a file rather than a directory.  This will cause
> `p.mkdir()` below to raise NotADirectoryError.
>
> The existing code in mbox.py:395 already solves this correctly:
>
>     gitargs = ['rev-parse', '--git-dir']
>     ecode, out = b4.git_run_command(topdir, gitargs, logstderr=True)
>
> Consider using `git rev-parse --git-dir` to obtain the actual git
> directory and then creating a `b4/` subdirectory under it.

The current code in the b4 tree includes my changes from Nov. 19, commit
ab9639a7685a0e488f7d32783d55aaa2101acc68, and that code doesn't do what
is shown here. I think there were more iterations. I'm not sure why
we're discussing this old thread.

-Dave