Re: [PATCH b4 v3] ez: allow cleaning multiple branches at once

["Antonin Godard" <antonin.godard@bootlin.com>]

Hi,

On Wed Feb 25, 2026 at 3:27 PM CET, Konstantin Ryabitsev wrote:
> On Wed, 25 Feb 2026 13:59:48 +0100, Antonin Godard <antonin.godard@bootlin.com> wrote:
>> Allow "b4 prep --cleanup" to cleanup multiple branches in one go. If an
>> error occurs (branch not known/empty branch/currently checked out), just
>> return to continue cleaning up branches. Give the user multiple options:
>> "y" to cleanup, "n" to skip, "q" to abort the cleanup, "s" to show
>> the branch log with diffs, and "?" to print help about these options.
>> 
>> Passing nothing to --cleanup still shows the available branches to
>> cleanup.
>
> I have a few tiny notes, but I hope we can get them addressed. :)
>
>> -    mybranch = param
>> -    if not b4.git_branch_exists(None, mybranch):
>> -        logger.critical('Not a known branch: %s', mybranch)
>> -        sys.exit(1)
>> -    is_prep_branch(mustbe=True, usebranch=mybranch)
>> -    base_commit, start_commit, end_commit = get_series_range(usebranch=mybranch)
>> +    if not is_prep_branch(usebranch=branch):
>> +        logger.error(f'ERROR: {branch} is not a prep-managed branch')
>
> This is a nitpick, but in general it's preferred to use %-formatting for 
> logger calls, because this skips unnecessary interpolation when not 
> needed. So, in this case it should be:
>
>   logger.error('ERROR: %s is not a prep-managed branch', branch)

TIL! I'll send a v4. Thanks.

Antonin