From: "Theodore Ts'o" <tytso@mit.edu>
To: Mark Brown <broonie@kernel.org>
Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
Rob Herring <robh@kernel.org>, Lee Jones <lee.jones@linaro.org>,
users@linux.kernel.org, tools@linux.kernel.org
Subject: Re: Acked-by missed when applying
Date: Tue, 5 Oct 2021 09:25:52 -0400 [thread overview]
Message-ID: <YVxSYIptCkSZF084@mit.edu> (raw)
In-Reply-To: <YVxJ2Q21vstxIDsX@sirena.org.uk>
On Tue, Oct 05, 2021 at 01:49:29PM +0100, Mark Brown wrote:
> On Tue, Oct 05, 2021 at 08:45:36AM -0400, Konstantin Ryabitsev wrote:
> > On Tue, Oct 05, 2021 at 07:22:00AM -0500, Rob Herring wrote:
>
> > > Because you applied the first v2 patch, not the second v2 threaded to
> > > the 1st one that Greg acked.
>
> > Should we issue a warning in such cases? E.g:
>
> > WARNING: Identically numbered patches found, will use the latest by date.
> > Download and edit the mailbox manually for any other outcome.
>
> Please! In general the messages b4 prints when it resolves any
> ambiguity are really helpful.
+1. If b4 could give us the message id's and message time stamps,
that would be great. Even better, perhaps b4 could download both, and
diff the two patches, which might give us some clue if it was just the
same patch accidentally sent twice, or change in the commit
description (maybe the sender forgot to add some trailers?), or the
commit diffs are actually different, in which case maybe the sender
forgot to increment the version number.
- Ted
next prev parent reply other threads:[~2021-10-05 13:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 8:01 Acked-by missed when applying Lee Jones
2021-10-05 12:22 ` Rob Herring
2021-10-05 12:45 ` Konstantin Ryabitsev
2021-10-05 12:49 ` Mark Brown
2021-10-05 13:25 ` Theodore Ts'o [this message]
2021-10-05 13:22 ` Lee Jones
2021-10-05 12:48 ` Lee Jones
2021-10-05 12:53 ` Konstantin Ryabitsev
2021-10-05 13:12 ` Lee Jones
2021-10-05 13:37 ` Mauro Carvalho Chehab
2021-10-05 13:50 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVxSYIptCkSZF084@mit.edu \
--to=tytso@mit.edu \
--cc=broonie@kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=robh@kernel.org \
--cc=tools@linux.kernel.org \
--cc=users@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox