* Re: "b4 trailers -u" chops off patch subjects
[not found] <YyzWI/zCGli+3UcQ@google.com>
@ 2022-09-22 21:42 ` Dmitry Torokhov
2022-09-22 22:05 ` Konstantin Ryabitsev
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Torokhov @ 2022-09-22 21:42 UTC (permalink / raw)
To: Konstantin Ryabitsev; +Cc: users, tools
[CC-ing mailing lists...]
On Thu, Sep 22, 2022 at 02:39:47PM -0700, Dmitry Torokhov wrote:
> Hi Konstantin,
>
> It looks like "b4 trailers -u" removes patch subjects from commits,
> leaving only body:
>
> dtor@dtor-ws:~/kernel/linux-next (get_gpiod_from_child-remove)$ git log --oneline -5
> a31ab9768271 (HEAD -> get_gpiod_from_child-remove) gpiolib: remove devm_fwnode_get_[index_]gpiod_from_child()
> 359e79d23882 leds: lgm-sso: switch to using devm_fwnode_gpiod_get()
> 991ff1b001c0 leds: gpio: switch to using devm_fwnode_gpiod_get()
> 7820e4c4f360 Get rid of devm_fwnode_get_[index_]gpiod_from_child()
> 483fed3b5dc8 (tag: next-20220921, origin/master, origin/HEAD) Add linux-next specific files for 20220921
> dtor@dtor-ws:~/kernel/linux-next (get_gpiod_from_child-remove)$ b4 trailers -u
> Calculating patch-ids from 2 commits
> Checking change-id "20220902-get_gpiod_from_child-remove-a62638849e91"
> Grabbing search results from lore.kernel.org
> ---
> leds: gpio: switch to using devm_fwnode_gpiod_get()
> + Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> (✓ DKIM/gmail.com)
> + Reviewed-by: Linus Walleij <linus.walleij@linaro.org> (✓ DKIM/linaro.org)
> leds: lgm-sso: switch to using devm_fwnode_gpiod_get()
> + Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> (✓ DKIM/gmail.com)
> + Reviewed-by: Linus Walleij <linus.walleij@linaro.org> (✓ DKIM/linaro.org)
> gpiolib: remove devm_fwnode_get_[index_]gpiod_from_child()
> + Acked-by: Bartosz Golaszewski <brgl@bgdev.pl> (✓ DKIM/bgdev-pl.20210112.gappssmtp.com)
> + Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> (✓ DKIM/gmail.com)
> + Reviewed-by: Linus Walleij <linus.walleij@linaro.org> (✓ DKIM/linaro.org)
> ---
> Invoking git-filter-repo to update trailers.
> New history written in 0.12 seconds...
> Completely finished after 0.52 seconds.
> Trailers updated.
> dtor@dtor-ws:~/kernel/linux-next (get_gpiod_from_child-remove)$ git log --oneline -5
> fcd562595314 (HEAD -> get_gpiod_from_child-remove) Now that there are no more users of these APIs in the kernel we can remove them.
> 34557baea2d5 devm_fwnode_get_gpiod_from_child() is going away as the name is too unwieldy, let's switch to using the new devm_fwnode_gpiod_get().
> 443abc336e8d devm_fwnode_get_gpiod_from_child() is going away as the name is too unwieldy, let's switch to using the new devm_fwnode_gpiod_get().
> 7820e4c4f360 Get rid of devm_fwnode_get_[index_]gpiod_from_child()
> 483fed3b5dc8 (tag: next-20220921, origin/master, origin/HEAD) Add linux-next specific files for 20220921
> dtor@dtor-ws:~/kernel/linux-next (get_gpiod_from_child-remove)$
>
> Please see how patches changed after running b4. This is with ToT checkout:
>
> 6c215d8 ez: don't send a cover letter for a 1-patch series
>
> Thanks!
>
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: "b4 trailers -u" chops off patch subjects
2022-09-22 21:42 ` "b4 trailers -u" chops off patch subjects Dmitry Torokhov
@ 2022-09-22 22:05 ` Konstantin Ryabitsev
2022-09-23 16:46 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Konstantin Ryabitsev @ 2022-09-22 22:05 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: users, tools
On Thu, Sep 22, 2022 at 02:42:59PM -0700, Dmitry Torokhov wrote:
> > It looks like "b4 trailers -u" removes patch subjects from commits,
> > leaving only body:
Yikes. This is fixed in master/stable-0.10.y. I'd just introduced it earlier
today due to a refactor. I need to add this to the tests.
Thank you for the report.
-K
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: "b4 trailers -u" chops off patch subjects
2022-09-22 22:05 ` Konstantin Ryabitsev
@ 2022-09-23 16:46 ` Dmitry Torokhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2022-09-23 16:46 UTC (permalink / raw)
To: Konstantin Ryabitsev; +Cc: users, tools
On Thu, Sep 22, 2022 at 06:05:23PM -0400, Konstantin Ryabitsev wrote:
> On Thu, Sep 22, 2022 at 02:42:59PM -0700, Dmitry Torokhov wrote:
> > > It looks like "b4 trailers -u" removes patch subjects from commits,
> > > leaving only body:
>
> Yikes. This is fixed in master/stable-0.10.y. I'd just introduced it earlier
> today due to a refactor. I need to add this to the tests.
>
> Thank you for the report.
Thank you for the quick fix. I can confirm it is working for me now.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-23 16:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <YyzWI/zCGli+3UcQ@google.com>
2022-09-22 21:42 ` "b4 trailers -u" chops off patch subjects Dmitry Torokhov
2022-09-22 22:05 ` Konstantin Ryabitsev
2022-09-23 16:46 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox