From: Nicolas Schier <nsc@kernel.org>
To: Christian Brauner <brauner@kernel.org>
Cc: "Kernel.org Tools" <tools@kernel.org>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Subject: Re: [PATCH b4 0/2] review-tui: don't gpg-sign throwaway test-apply commits
Date: Thu, 23 Jul 2026 17:33:15 +0200 [thread overview]
Message-ID: <amI0O4M8Ie4qK9Yk@levanger> (raw)
In-Reply-To: <20260723-work-b4-testapply-nosign-v1-0-a7cb7105e06f@kernel.org>
On Thu, Jul 23, 2026 at 10:33:34AM +0200, Christian Brauner wrote:
> The take/rebase/target/base modals check whether a series applies
> cleanly by running a real git-am into a temporary worktree and rebase
> additionally probes with a cherry-pick. The four modal probes run from
> worker threads while the TUI keeps the terminal.
>
> With commit.gpgsign=true and pinentry-curses git tries to sign every
> probe commit. pinentry then pops up on the tty that Textual owns in raw
> mode. The TUI repaints over the PIN dialog and its input reader swallows
> the keystrokes and so gpg never gets the PIN and the apply hangs. With a
> card-backed key this reproduces on every take.
yes, thanks a lot!
Tested-by: Nicolas Schier <nsc@kernel.org>
prev parent reply other threads:[~2026-07-23 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 8:33 [PATCH b4 0/2] review-tui: don't gpg-sign throwaway test-apply commits Christian Brauner
2026-07-23 8:33 ` [PATCH b4 1/2] " Christian Brauner
2026-07-23 8:33 ` [PATCH b4 2/2] tests: guard the test-apply probes against gpg signing Christian Brauner
2026-07-23 15:33 ` Nicolas Schier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amI0O4M8Ie4qK9Yk@levanger \
--to=nsc@kernel.org \
--cc=brauner@kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=tools@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox