Re: b4 review tui: too smart reply features?

[Matthieu Baerts <matttbe@kernel.org>]

Hi Konstantin,

On 11/06/2026 03:56, Konstantin Ryabitsev wrote:
> On Tue, Apr 28, 2026 at 12:52:01PM +0200, Matthieu Baerts wrote:
>> Hi Konstantin,
>>
>> I'm still trying 'b4 review tui', and something that bothers me is when
>> my replies are mangled. I have three examples.
> 
> Okay, the latest master has revamped that quite a bit. I was also not really
> happy with the way I kept fighting with the tooling, which is the opposite of
> where I want to go. I had the bright idea to move some of the functionality
> into a vim plugin instead of doing it in b4 directly -- this way you still get
> most of the neat features but without the inability to undo or forced/awkward
> quote trimming.
> 
> Can you try it out and see if you're fighting with the current master less?

Thank you for the update, and sorry for the delay!

I just retried, and it is indeed much better now! Yet, I still have an
issue with trailers, e.g.

  Please add a Fixes tag. Here I guess it should be:

  Fixes: (...)

The Review view then correctly showed my comment with the Fixes tag, but
*I think* the Fixes tag was not visible in green at the bottom left (not
sure, because I also added a Reviewed-by tag after the reply). When
looking at the 'email mode' view, the Fixes tag got dropped, leaving 2
empty lines around.

Back to the 'reply' view, vim showed all lines ending with ^M, and the
line starting with 'Fixes:' was no longer there. Adding it back re-added
it to the other views, and the Fixes tag was also listed at the bottom
left in the 'review' view, but I could see extra new lines due to all
these \r. Stripping them from the 'reply' view fixes all the issues, and
I was able to send the reply with both my Fixes and Reviewed-by tags.

Any idea was caused that? :)

BTW, after having sent a reply, it appears a few seconds later as unread
in my inbox. I guess only a filter on the inbox side can help to mark
them as read, right?

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.