Re: [b4] add notes to patch for commit with git-notes?

[Matthieu Baerts <matttbe@kernel.org>]

Hi Quentin,

On 02/09/2024 18:51, Quentin Schulz wrote:
> I think it should be possible to use git-notes for the latter?

Please note :) that these notes can be easily dropped by b4 itself when
editing commits because it uses 'git filter-repo' to do so [1]. In other
words, these notes will be dropped when using 'b4 trailers', or when
using some 'b4 prep' commands when the cover-letter is stored in a
dedicated commit.

> The diff we had for b4 to make this work is the following:

The diff you attached has already proposed before in [2], but not
applied because the notes can be dropped.

> Let me know if git-notes would be fine and the direction to go for
> patches. Thanks!

Unfortunately, I don't think that's the right direction. The alternative
is to add the notes in the commit message, at the end, under '---' [3].
Maybe the direction to take is to document this alternative :)

[1]
https://lore.kernel.org/tools/20220929074717.u2xfvfwq4ki732tw@wittgenstein/T/
[2]
https://lore.kernel.org/tools/20240131223054.371692-1-Frank.Li@nxp.com/T/
[3]
https://lore.kernel.org/tools/jx7vyqdj3qt2zwgsxh6hjac6osr52n2vcmkj2pg3elapcth62m@jtl27si2pa3g/

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.