tools.linux.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Herbert <marc.herbert@linux.intel.com>
To: tools@kernel.org
Subject: Single patch and cover letter: inconsistent Subject line behavior
Date: Wed, 05 Nov 2025 15:23:20 -0800	[thread overview]
Message-ID: <m21pmcvzbr.fsf@C02X38VBJHD2mac.jf.intel.com> (raw)


The current documentation and cover-letter template state this:

> When you only have a single patch, b4 should "mix-in" the contents of
> the cover letter into the "under-the-cut" portion of the patch itself,
> where it serves as a source of additional information for the reviewers,
> but never makes it into the actual commit.

I noticed that the "under-the-cut" portion omits the _subject line_ of
the cover letter. That does not seem documented. So I wrote a
documentation patch and I was about to send it. But after testing a bit
more I noticed that the first and second lines of the cover letter _are_
included in the "under-the-cut" portion when the second line of the
cover letter file is not empty. Is that the intended behavior? Or maybe
more "accidental" and caused by whatever library parses the cover letter
file? Either way there is at least some documentation gap.


Correct subject line followed by empty line: OMITTED
   < empty line >
Body or not, included if any
Body or not, included if any


"Malformed subject" 1st line NOT followed by empty line: INCLUDED
   NOT empty 2nd line, INCLUDED
Body or not, included if any
Body or not, included if any

                 reply	other threads:[~2025-11-05 23:23 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m21pmcvzbr.fsf@C02X38VBJHD2mac.jf.intel.com \
    --to=marc.herbert@linux.intel.com \
    --cc=tools@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).