From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBDD64A32 for ; Mon, 12 Jan 2026 11:11:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768216301; cv=none; b=LSiLhUjG14mZSVzTu5qjCsjxI29Q4DXu+XXrc4EoyrrkVs8UXTTpi+jKuoEi9V2RiDkQ03oEsHBte7nr8bW/RzrjSJjMaECEL2TnqWCaHXCtbrPodLl/V77ZDe8fZMAHPnEwUDeoTDcrwN8y2VZ0KDwti36t1aZsO2LGZQEijUw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768216301; c=relaxed/simple; bh=3MmY4S16UqeLLgW5B2dYUdyba/3vOehmRJzW65Vwh/Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=QAOWaR6C+pi/MHHap05iRw+cYb8Tiamt0iXAP8Gc/CD1FZ9+Bum761Ys3dtwW3DUtfaR8k6jz+F+Z9KMFermkdRk4H+DOekuR22GDmw2lC+PcZP7ajDZHS7LuCFaQ93G3bw7+BzB3xVQr3G//VgpZqkGAGsCvMVK3fHP/Mht8bc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=keystrike.com; spf=pass smtp.mailfrom=keystrike.com; dkim=pass (2048-bit key) header.d=keystrike.com header.i=@keystrike.com header.b=GlviKq3c; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=keystrike.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=keystrike.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=keystrike.com header.i=@keystrike.com header.b="GlviKq3c" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-6505d3adc3aso9851629a12.1 for ; Mon, 12 Jan 2026 03:11:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=keystrike.com; s=google; t=1768216297; x=1768821097; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=9zWG+aiASHdD3hTB6dwBs11/SmknTmZoFc4cir8N7x0=; b=GlviKq3c0If4XErR7rU20S7gEtdGrMzBXnKZsQ8FuPPXye3VpXNvu0xu1SnhvdPexc YIZwl/2JlnpR2r/maqIcLXB7DYtOWjGXt7MsEB0KJjp20UnLCMIK/L9H2x1cnvMHa97R +ap08OVtT3OvjcrY/kIORI7oKOe/88zSgBQccb/Iqhd8myod3WBVtKfDO6PTptfX7vBc kt1oXokU3H+UbsHkVRrf/aN7C8mmWzi8/jn25jq9JhyhSSPdkfAgl4mFC872xoRe3P4L Uatl2/9S8+/9BENUw4Cg6EcDzrbQbGV+BwewbBE0HeDVPiZJalSKCTQkERKixvpNiBRs SOcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768216297; x=1768821097; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9zWG+aiASHdD3hTB6dwBs11/SmknTmZoFc4cir8N7x0=; b=IjQnUrQtOBV646BJJ02iHq01DVnTfGXvSalixX+pn5YzzsYdjIYCODmk7fsgt5HiDn 06GfvqGDPc6b0hIQdyvqnAt4bpCZI9+lY0eTOvPRf9WUtFIlhtC7Su1H+M6ARTsc76ze OSzM7YmGfMlgzoWbecUpXBeVaox1lDGI7Ehu4JRTGvnnE5kbMEhgENG4UJpDL5Nb6TSf I9/mcwPPTAWaMsqU4UCve+tvXicLAWbzXokguAPn1Rwaprc3zuTI69WPB7uV5UWgYXwi z4e4Gh/LoLNWMramf/w6e4afkS6UtF+oVYr78F+uCKajesw8CA4RQqmcCUJNqb1fzFfx axNw== X-Gm-Message-State: AOJu0YzyT/MePnvQh4VMItEy47udQAZZcyIfzfoK7DXHUBTE5HJwuZSA e3lq6GMQLerRZTggZiRYGACIirfslsioDn64s48aqFWObiH33HyIcMKhYO7MgYYSvwcM/tcH6Qi Z4UPq+vg= X-Gm-Gg: AY/fxX6uDVzNVnS0K+IATCJiHEscW/N7xroagEbstdKUYLg2Fk9FXpbqgUOqi9TE/bn IR2egPTqeP0gf9CQShdr2++lynjwlN/M0W8fBqgI6y42w1RM/x+Yb6X166slYekXZfkYauR3q8V NKFTv7yYRge3wAK34zhcZ8EyEF08nj++pQSyy/sEy8T+7961qtL8ixAfGH7IIPZqPRJ2U1hhPpn HD7AFphWbhGyouqGUu0oA++IDx7JJlAtZx4hqP2Tj62laJIlNNmb3Z9kYyyxrZJxAfvyhpNNXGL TSeaCM2U7FbO+OHnsPdmrxxb/u4WoRftoKWWyCspi+0QDtPVaD1PZDj6v4mxU3Yu0QEWn8YFmt3 L8r2U1BnQ9WWyA6YdDg05pM4WJOCekMi0TWSN529o3cPigO0HT1iD40kZcoRqSKBc5iWV+QZQxN 1JpRjHih1ChyChiqcX6Jxbu1BIMGvsFr/+A4yBI+4bTAkp52k/rQ== X-Google-Smtp-Source: AGHT+IHZ+ZeyPSzyytvM53lLihHvs7elfbp08Vma3vXlN4dQ8EScHEBKXlqDN2JVcTDqIMlXTJ3QXQ== X-Received: by 2002:a17:906:f599:b0:b83:288a:2bce with SMTP id a640c23a62f3a-b84451f1870mr1870291966b.24.1768216296898; Mon, 12 Jan 2026 03:11:36 -0800 (PST) Received: from dev.. (nova-046-182-188-031.nat.novanet.is. [46.182.188.31]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-b873051cc88sm20198166b.7.2026.01.12.03.11.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 03:11:36 -0800 (PST) From: =?UTF-8?q?P=C3=A9tur=20Run=C3=B3lfsson?= To: tpm-protocol@lists.linux.dev Cc: jarkko@kernel.org Subject: [PATCH RESEND] fix(data): correct type for TpmSignCommand.in_scheme Date: Mon, 12 Jan 2026 11:10:05 +0000 Message-ID: <20260112111111.26293-1-petur@keystrike.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: tpm-protocol@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable The type of the inScheme parameter for the TPM_Sign command is TPMT_SIG_SCHEME+ ([1], Table 109). Added test message scraped from strace output of Esys_Sign(). [1] https://trustedcomputinggroup.org/wp-content/uploads/Trusted-Platform-M= odule-2.0-Library-Part-3-Version-184_pub.pdf Signed-off-by: P=C3=A9tur Run=C3=B3lfsson --- src/frame/data.rs | 6 +++--- tests/message.txt | 3 ++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/frame/data.rs b/src/frame/data.rs index 9bc27ca..668f672 100644 --- a/src/frame/data.rs +++ b/src/frame/data.rs @@ -14,8 +14,8 @@ use crate::{ TpmSe, TpmSu, TpmaLocality, TpmiAlgCipherMode, TpmiAlgHash, TpmiEc= cKeyExchange, TpmiYesNo, TpmlAcCapabilities, TpmlAlg, TpmlCc, TpmlDigest, TpmlDigestValues,= TpmlPcrSelection, TpmsAcOutput, TpmsAlgorithmDetailEcc, TpmsCapabilityData, TpmsCont= ext, TpmsTimeInfo, - TpmtHa, TpmtKdfScheme, TpmtPublicParms, TpmtRsaDecrypt, TpmtSignat= ure, TpmtSymDef, - TpmtSymDefObject, TpmtTkAuth, TpmtTkCreation, TpmtTkHashcheck, Tpm= tTkVerified, + TpmtHa, TpmtKdfScheme, TpmtPublicParms, TpmtRsaDecrypt, TpmtSigSch= eme, TpmtSignature, + TpmtSymDef, TpmtSymDefObject, TpmtTkAuth, TpmtTkCreation, TpmtTkHa= shcheck, TpmtTkVerified, }, frame::TpmHeader, }; @@ -2552,7 +2552,7 @@ tpm_struct! { handles: 1, parameters: { pub digest: Tpm2bDigest, - pub in_scheme: TpmtSignature, + pub in_scheme: TpmtSigScheme, pub validation: TpmtTkHashcheck, } } diff --git a/tests/message.txt b/tests/message.txt index 38bb576..09d6448 100644 --- a/tests/message.txt +++ b/tests/message.txt @@ -9,7 +9,8 @@ 00000137 Command 0000 80020000002a0000013740000001010000000000000c40000009= 00000000033132330004deadbeef0000 00000176 Command 0000 80020000003f0000017640000001400000010000001040000009= 0000800007617574683132330010aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa0000010010000b 00000176 Command 0000 80010000002b0000017640000007400000070010aaaaaaaaaaaa= aaaaaaaaaaaaaaaaaaaa0000000010000b -0000015D Command 0000 80010000005C0000015D800000010020aaaaaaaaaaaaaaaaaaaa= aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa0005000Bbbbbbbbbbbbbbbbbbbbbbbb= bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb8024400000070000 +0000015D Command 0000 80010000003C0000015D800000010020aaaaaaaaaaaaaaaaaaaa= aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa0005000B8024400000070000 +0000015D Command 0000 8002000000c90000015d80fffffe00000049020000000020013e= 913204ba4c050b520e5c1b298183877ba1b96b986f9cbc3fb52ec82a68fa21002081d177bfa= 62f2442b571932ebc03ee9f48e28f553a3272003d387ceb31857eac00205cb67f3ab8c70a63= af698f78e9378254e643786a0bd31301744d15c15805c6e30018000b8024400000010040875= f530de79f51f5db75e9488c7bb07b7906211e486c675791b6bb8ccdd3357ff59a1603df6d27= d6814e81621586eaad9af3564ff4032e3085bcd20c94a854e6 0000017A Response 0000 80010000020b0000000001000000060000003f00000100322e3= 0000000010100000000000001020000008a000001030000000800000104000007e200000105= 4946580000000106534c4239000001073637300000000108000000000000010900000000000= 0010a000000000000010b000700550000010c0011cb000000010d000004000000010e000000= 040000010f00000007000001100000000300000111000000400000011200000018000001130= 0000003000001140000ffff0000011600000008000001170000080000000118000000060000= 0119000040000000011a0000000b0000011b000000060000011c000000800000011d000000f= f0000011e0000058c0000011f0000058c0000012000000020000001210000038f0000012200= 0001ee000001230000000100000124000000000000012500000103000001260000000000000= 12700000000000001280000008000000129000000610000012a000000600000012b00000001= 0000012c000003000000012d000000010000012e00000200000002000000000400000201800= 0000f000002020000000d000002030000000000000204000000030000020500000000000002= 060000004000000207000000040000020800000001000002090000000c0000020a000000020= 000020b0000000c0000020c000000000000020d000000020000020e000000000000020f0000= 001f0000021000000258 00000176 Response 0000 8001000000300000000002000000002000647915de6106c955b= 26456b8b8a3b10546fa446405d4eb2e1fb0247fb52080 0000017A Response 0000 8001000000170000000000000000080000000200030010 --=20 2.43.0