From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 821A4191F66 for ; Tue, 2 Sep 2025 09:15:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756804538; cv=none; b=SlTt8dN0gFUv92L8CwNv9ZCWrtML+mt2GJDX+pcfTCquc7EIWuBG0u9JfhiN0uu3D8vIncG7UbkPnHE+0rFwIaDH+8qDWETUDm8XFIYlzbXph5FhfADac9SOZTDEway9EQmTkcmiHIeqZPEL2ZwEHsIdOz09cIUq61F7L7EMTxQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756804538; c=relaxed/simple; bh=yJda1Vj+FpdXRDr5+nleM/pWE/29T2u/rMOMTfc4dQk=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=U9dzGH7FHRl93Zw3sHF5Wij3Sh9l6MUmzQ2PGPu6K+aLcCuNGMpEQbwBPstTLl/Ct5vT5YnPhMFL7N5BpelYdRAgUfCXEHByq1CyRNtUbysXhPNudqfh2oZLsKdEI1+4wrQ3I2dqxXBEO6knJd0yf68OpoqyHA+qyxoniCw5p/0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=b+UN3mru; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="b+UN3mru" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF31EC4CEED for ; Tue, 2 Sep 2025 09:15:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756804538; bh=yJda1Vj+FpdXRDr5+nleM/pWE/29T2u/rMOMTfc4dQk=; h=Date:From:To:Subject:References:In-Reply-To:From; b=b+UN3mruL4BA7iVcYncaC5UdCby1+QKjFHAv5V4ASwHp2/W/bqwXnyZ0vf7N9inE3 oDCZPjTPvyc50WW7BhzLwXAMMOhCPGNpHkeoNydLtjTWFlzaHrMRpPdvYl9rBagqfX l3GvFWgHdC984jZqEFJNHfG3cJgACtw54p8DmkwKemk8aGK10B1vaUXsUO4bj6LopW CdD9LivS+6F5TYo2AzR7gS1T6PKXy/OQ5FixdkGBfvddxGReQ4GIg152ougf86QGXZ tJ2UfNk+4ykGCsQ/ECOl75uWKkLLaixjpsEU7hUpqWugTKp02Zo/V7yF5VouyRc6Ys r83As2gE9Q4Og== Date: Tue, 2 Sep 2025 12:15:34 +0300 From: Jarkko Sakkinen To: tpm-protocol@lists.linux.dev Subject: Re: [PATCH] tests: add test_response_start_auth_session_no_sessions_2 Message-ID: References: <20250902012620.2790121-1-jarkko@kernel.org> Precedence: bulk X-Mailing-List: tpm-protocol@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250902012620.2790121-1-jarkko@kernel.org> On Tue, Sep 02, 2025 at 04:26:20AM +0300, Jarkko Sakkinen wrote: > Add a test taken from tpm2sh trace output, which reveals a bug in the > response parser not catched by previous tests. > > Signed-off-by: Jarkko Sakkinen > --- > This is a embarrassing critical bug and damage from refactorization > where `tpm_response!` macro was removed which was a compilicated task. > The bright side is that the quality of test suite also leveled up > as consequence and missing something as critical as this will become > factors more difficult. > > Luckily response parsing it not too complicated, and this can be fixed > quite easily. Dispatcher must be internally updated to pass the runtime > parsed tag forward (just like it does for cc). I.e. a few macro updates > should do. What happened here basically was that I was so focused on command parsing, which felt more complicated (given e.g. how authorization area is located) that I made some really unconsidered change on response parser. It's easy to fix, and in the end better than having this other way around. BR, Jarkko