From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Nayna Jain <nayna@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
tpmdd-devel@lists.sourceforge.net
Subject: Re: [tpmdd-devel] [PATCH v5 3/3] tpm: add securityfs support for TPM 2.0 firmware event log
Date: Thu, 24 Nov 2016 21:51:03 -0500 [thread overview]
Message-ID: <11f97863-aa40-a9aa-836f-4b446faf1ed3@linux.vnet.ibm.com> (raw)
In-Reply-To: <20161124211057.xynmfteky5r7uc27@intel.com>
On 11/24/2016 04:10 PM, Jarkko Sakkinen wrote:
> On Wed, Nov 23, 2016 at 12:27:37PM -0500, Nayna Jain wrote:
>> Unlike the device driver support for TPM 1.2, the TPM 2.0 does
>> not support the securityfs pseudo files for displaying the
>> firmware event log.
>>
>> This patch enables support for providing the TPM 2.0 event log in
>> binary form. TPM 2.0 event log supports a crypto agile format that
>> records multiple digests, which is different from TPM 1.2. This
>> patch enables the tpm_bios_log_setup for TPM 2.0 and adds the
>> event log parser which understand the TPM 2.0 crypto agile format.
>>
>> Signed-off-by: Nayna Jain <nayna@linux.vnet.ibm.com>
> I don't want to say much about this before I've tested it. I wonder
> what cheap hardware I could use to test this. Any advice is on this
> from anyone is much appreciated.
Virtual hardware would be cheap :-)
I tested this series with QEMU + vTPM + SeaBIOS with TPM 1.2 + TPM 2
support (basing the log on ACPI). I had to fix an endianess issue on the
SeaBIOS side, which made it work. So for this version of the patches I
can give it my tested-by:
Tested-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
>
> /Jarkko
>
> ------------------------------------------------------------------------------
> _______________________________________________
> tpmdd-devel mailing list
> tpmdd-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
>
next prev parent reply other threads:[~2016-11-25 2:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 17:27 [PATCH v5 0/3] tpm: securityfs support for TPM 2.0 firmware event log Nayna Jain
2016-11-23 17:27 ` [PATCH v5 1/3] tpm: move event log init functions to tpm_eventlog_init.c Nayna Jain
[not found] ` <1479922057-8752-2-git-send-email-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-11-23 19:38 ` Jason Gunthorpe
[not found] ` <20161123193830.GB13927-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-11-24 8:01 ` Nayna
[not found] ` <58369E3F.40509-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-11-24 16:43 ` Jason Gunthorpe
2016-11-24 16:50 ` Nayna
2016-11-24 21:01 ` Jarkko Sakkinen
[not found] ` <20161124210105.ykmbednlmae52tla-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-11-25 19:43 ` Jason Gunthorpe
[not found] ` <1479922057-8752-1-git-send-email-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-11-23 17:27 ` [PATCH v5 2/3] tpm: enhance read_log_of() to support Physical TPM event log Nayna Jain
[not found] ` <1479922057-8752-3-git-send-email-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-11-23 19:37 ` Jason Gunthorpe
2016-11-24 7:53 ` Nayna
2016-11-24 21:06 ` Jarkko Sakkinen
2016-11-23 17:27 ` [PATCH v5 3/3] tpm: add securityfs support for TPM 2.0 firmware " Nayna Jain
[not found] ` <1479922057-8752-4-git-send-email-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-11-24 21:10 ` Jarkko Sakkinen
2016-11-25 2:51 ` Stefan Berger [this message]
2016-11-25 8:11 ` [tpmdd-devel] " Jarkko Sakkinen
[not found] ` <11f97863-aa40-a9aa-836f-4b446faf1ed3-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-11-26 15:24 ` Jarkko Sakkinen
[not found] ` <20161124211057.xynmfteky5r7uc27-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-11-25 19:43 ` Jason Gunthorpe
2016-11-26 12:59 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11f97863-aa40-a9aa-836f-4b446faf1ed3@linux.vnet.ibm.com \
--to=stefanb@linux.vnet.ibm.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nayna@linux.vnet.ibm.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).