From: Stefan Berger <stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Cc: dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org
Subject: [PATCH v5 4/5] Initialize TPM and get durations and timeouts
Date: Mon, 8 Feb 2016 14:27:07 -0500 [thread overview]
Message-ID: <1454959628-30582-5-git-send-email-stefanb@linux.vnet.ibm.com> (raw)
In-Reply-To: <1454959628-30582-1-git-send-email-stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Add the retrieval of TPM 1.2 durations and timeouts. Since this requires
the startup of the TPM, do this for TPM 1.2 and TPM 2.
To not allow to interleave with commands from user space, so send the
TPM_Startup as the first command. The timeouts can then be gotten at any
later time, even interleaved with commands from user space.
Signed-off-by: Stefan Berger <stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
---
drivers/char/tpm/tpm-vtpm.c | 58 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 58 insertions(+)
diff --git a/drivers/char/tpm/tpm-vtpm.c b/drivers/char/tpm/tpm-vtpm.c
index 6ee1e44..d9fd797 100644
--- a/drivers/char/tpm/tpm-vtpm.c
+++ b/drivers/char/tpm/tpm-vtpm.c
@@ -41,6 +41,7 @@ struct vtpm_dev {
long state;
#define STATE_OPENED_BIT 0
+#define STATE_INIT_VTPM 1
spinlock_t buf_lock; /* lock for buffers */
@@ -52,6 +53,8 @@ struct vtpm_dev {
size_t resp_len; /* length of queued TPM response */
u8 resp_buf[TPM_BUFSIZE]; /* response buffer */
+ struct work_struct work; /* task that retrieves TPM timeouts */
+
struct list_head list;
};
@@ -292,6 +295,9 @@ static int vtpm_tpm_op_send(struct tpm_chip *chip, u8 *buf, size_t count)
spin_unlock(&vtpm_dev->buf_lock);
+ /* sync for first startup command */
+ set_bit(STATE_INIT_VTPM, &vtpm_dev->state);
+
wake_up_interruptible(&vtpm_dev->wq);
return rc;
@@ -323,6 +329,52 @@ static const struct tpm_class_ops vtpm_tpm_ops = {
};
/*
+ * Code related to the startup of the TPM 2 and startup of TPM 1.2 +
+ * retrieval of timeouts and durations.
+ */
+
+static void vtpm_dev_work(struct work_struct *work)
+{
+ struct vtpm_dev *vtpm_dev = container_of(work, struct vtpm_dev, work);
+
+ if (vtpm_dev->flags & VTPM_FLAG_TPM2)
+ tpm2_startup(vtpm_dev->chip, TPM2_SU_CLEAR);
+ else {
+ /* we must send TPM_Startup() first */
+ tpm_startup(vtpm_dev->chip, TPM_ST_CLEAR);
+ tpm_get_timeouts(vtpm_dev->chip);
+ }
+}
+
+/*
+ * vtpm_dev_start_work: Schedule the work for TPM 1.2 & 2 initialization
+ */
+static int vtpm_dev_start_work(struct vtpm_dev *vtpm_dev)
+{
+ int sig;
+
+ INIT_WORK(&vtpm_dev->work, vtpm_dev_work);
+ schedule_work(&vtpm_dev->work);
+
+ /* make sure we send the 1st command before user space can */
+ sig = wait_event_interruptible(vtpm_dev->wq,
+ test_bit(STATE_INIT_VTPM, &vtpm_dev->state));
+ if (sig) {
+ cancel_work_sync(&vtpm_dev->work);
+ return -EINTR;
+ }
+ return 0;
+}
+
+/*
+ * vtpm_dev_stop_work: prevent the scheduled work from running
+ */
+static void vtpm_dev_stop_work(struct vtpm_dev *vtpm_dev)
+{
+ cancel_work_sync(&vtpm_dev->work);
+}
+
+/*
* Code related to creation and deletion of device pairs
*/
static void vtpm_dev_release(struct device *dev)
@@ -449,6 +501,10 @@ static struct file *vtpm_create_device_pair(
}
vtpm_dev->chip = chip;
+ rc = vtpm_dev_start_work(vtpm_dev);
+ if (rc)
+ goto err_vtpm_fput;
+
vtpm_new_pair->fd = fd;
vtpm_new_pair->major = MAJOR(vtpm_dev->chip->dev.devt);
vtpm_new_pair->minor = MINOR(vtpm_dev->chip->dev.devt);
@@ -476,6 +532,8 @@ err_delete_vtpm_dev:
*/
static void vtpm_delete_device_pair(struct vtpm_dev *vtpm_dev)
{
+ vtpm_dev_stop_work(vtpm_dev);
+
spin_lock(&driver_lock);
list_del_rcu(&vtpm_dev->list);
spin_unlock(&driver_lock);
--
2.4.3
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
next prev parent reply other threads:[~2016-02-08 19:27 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 19:27 [PATCH v5 0/5] Multi-instance vTPM driver Stefan Berger
[not found] ` <1454959628-30582-1-git-send-email-stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-02-08 19:27 ` [PATCH v5 1/5] Implement tpm_chip_free Stefan Berger
[not found] ` <1454959628-30582-2-git-send-email-stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-02-09 5:28 ` Jason Gunthorpe
2016-02-08 19:27 ` [PATCH v5 2/5] Implement driver for supporting multiple emulated TPMs Stefan Berger
2016-02-08 19:27 ` [PATCH v5 3/5] Make tpm_startup() available Stefan Berger
[not found] ` <1454959628-30582-4-git-send-email-stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-02-09 5:29 ` Jason Gunthorpe
[not found] ` <20160209052957.GC12657-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-09 11:22 ` Stefan Berger
2016-02-08 19:27 ` Stefan Berger [this message]
[not found] ` <1454959628-30582-5-git-send-email-stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-02-09 5:33 ` [PATCH v5 4/5] Initialize TPM and get durations and timeouts Jason Gunthorpe
[not found] ` <20160209053323.GD12657-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-09 16:19 ` Stefan Berger
[not found] ` <201602091626.u19GQpga021574@d01av02.pok.ibm.com>
[not found] ` <201602091626.u19GQpga021574-prK0F/7GlgzImUpY6SP3GEEOCMrvLtNR@public.gmane.org>
2016-02-09 16:52 ` Jason Gunthorpe
[not found] ` <20160209165228.GA14611-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-09 17:45 ` Stefan Berger
2016-02-10 3:56 ` Jarkko Sakkinen
[not found] ` <20160210035620.GB7161-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-10 5:15 ` Stefan Berger
[not found] ` <201602100515.u1A5FonT015847@d03av04.boulder.ibm.com>
[not found] ` <201602100515.u1A5FonT015847-2xHzGjyANq4+UXBhvPuGgqsjOiXwFzmk@public.gmane.org>
2016-02-10 8:12 ` Jarkko Sakkinen
[not found] ` <201602100515.u1A5FpFi002736@d03av02.boulder.ibm.com>
[not found] ` <201602100515.u1A5FpFi002736-nNA/7dmquNI+UXBhvPuGgqsjOiXwFzmk@public.gmane.org>
2016-02-10 16:28 ` Jason Gunthorpe
[not found] ` <20160210162809.GB20730-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-10 21:45 ` Stefan Berger
[not found] ` <201602102145.u1ALjSAs001597@d03av04.boulder.ibm.com>
[not found] ` <201602102145.u1ALjSAs001597-2xHzGjyANq4+UXBhvPuGgqsjOiXwFzmk@public.gmane.org>
2016-02-10 22:23 ` Jason Gunthorpe
[not found] ` <20160210222313.GA7047-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-11 0:38 ` Stefan Berger
[not found] ` <201602110038.u1B0cuE0030670@d03av05.boulder.ibm.com>
[not found] ` <201602110038.u1B0cuE0030670-3MP/CPU4Muo+UXBhvPuGgqsjOiXwFzmk@public.gmane.org>
2016-02-11 7:04 ` Jarkko Sakkinen
[not found] ` <20160211070426.GB9307-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-11 15:24 ` Stefan Berger
[not found] ` <201602111521.u1BFLS3f007520-8DuMPbUlb4HImUpY6SP3GEEOCMrvLtNR@public.gmane.org>
2016-02-11 16:51 ` Stefan Berger
[not found] ` <201602111534.u1BFYvRs019573@d01av03.pok.ibm.com>
[not found] ` <201602111534.u1BFYvRs019573-CUdSWdNILC7ImUpY6SP3GEEOCMrvLtNR@public.gmane.org>
2016-02-11 18:12 ` Jason Gunthorpe
[not found] ` <20160211181208.GA6285-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-11 19:10 ` Stefan Berger
[not found] ` <201602111911.u1BJB2nK017410@d01av03.pok.ibm.com>
[not found] ` <201602111911.u1BJB2nK017410-CUdSWdNILC7ImUpY6SP3GEEOCMrvLtNR@public.gmane.org>
2016-02-11 19:48 ` Jason Gunthorpe
[not found] ` <20160211194810.GA24211-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-11 22:10 ` Stefan Berger
[not found] ` <201602112210.u1BMAYPe015452@d03av01.boulder.ibm.com>
[not found] ` <201602112210.u1BMAYPe015452-Rn83F4s8Lwc+UXBhvPuGgqsjOiXwFzmk@public.gmane.org>
2016-02-11 22:18 ` Jason Gunthorpe
[not found] ` <20160211221822.GA16304-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-11 22:26 ` Stefan Berger
[not found] ` <201602112226.u1BMQZ59031657@d01av02.pok.ibm.com>
[not found] ` <201602112226.u1BMQZ59031657-prK0F/7GlgzImUpY6SP3GEEOCMrvLtNR@public.gmane.org>
2016-02-11 23:56 ` Jason Gunthorpe
[not found] ` <20160211235611.GB16304-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-12 3:56 ` Stefan Berger
[not found] ` <201602120356.u1C3usEe002034-2xHzGjyANq4+UXBhvPuGgqsjOiXwFzmk@public.gmane.org>
2016-02-12 18:13 ` Stefan Berger
[not found] ` <201602121813.u1CIDu4O015272@d01av01.pok.ibm.com>
[not found] ` <201602121813.u1CIDu4O015272-4ZtxiNBBw+3ImUpY6SP3GEEOCMrvLtNR@public.gmane.org>
2016-02-12 18:34 ` Jason Gunthorpe
[not found] ` <20160212183415.GA4289-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-14 6:37 ` Stefan Berger
[not found] ` <201602140637.u1E6baNX028563-2xHzGjyANq4+UXBhvPuGgqsjOiXwFzmk@public.gmane.org>
2016-02-16 16:44 ` Stefan Berger
[not found] ` <201602161648.u1GGmdZv000468@d01av03.pok.ibm.com>
[not found] ` <201602161648.u1GGmdZv000468-CUdSWdNILC7ImUpY6SP3GEEOCMrvLtNR@public.gmane.org>
2016-02-16 18:00 ` Jason Gunthorpe
[not found] ` <20160216180028.GA4967-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-16 19:26 ` Stefan Berger
[not found] ` <201602161927.u1GJRJL6016216@d01av01.pok.ibm.com>
[not found] ` <201602161927.u1GJRJL6016216-4ZtxiNBBw+3ImUpY6SP3GEEOCMrvLtNR@public.gmane.org>
2016-02-17 4:47 ` Jason Gunthorpe
[not found] ` <20160217044750.GB25049-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-18 3:52 ` Stefan Berger
[not found] ` <201602120353.u1C3rYif023135@d01av05.pok.ibm.com>
[not found] ` <201602120353.u1C3rYif023135-8DuMPbUlb4HImUpY6SP3GEEOCMrvLtNR@public.gmane.org>
2016-02-12 18:40 ` Jason Gunthorpe
[not found] ` <20160212184051.GB4289-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-12 20:31 ` Stefan Berger
[not found] ` <201602122031.u1CKVIOp028400@d03av03.boulder.ibm.com>
[not found] ` <201602122031.u1CKVIOp028400-MijUUJkLaQs+UXBhvPuGgqsjOiXwFzmk@public.gmane.org>
2016-02-12 20:39 ` Jason Gunthorpe
[not found] ` <20160212203956.GB10540-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-12 20:44 ` Stefan Berger
[not found] ` <201602122044.u1CKiMbR023495@d03av03.boulder.ibm.com>
[not found] ` <201602122044.u1CKiMbR023495-MijUUJkLaQs+UXBhvPuGgqsjOiXwFzmk@public.gmane.org>
2016-02-12 21:15 ` Jason Gunthorpe
[not found] ` <20160212211538.GA20737-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-12 22:23 ` Stefan Berger
[not found] ` <201602122223.u1CMNJXl023711-4ZtxiNBBw+3ImUpY6SP3GEEOCMrvLtNR@public.gmane.org>
2016-02-12 22:47 ` Stefan Berger
[not found] ` <201602122247.u1CMlFni023527@d03av04.boulder.ibm.com>
[not found] ` <201602122247.u1CMlFni023527-2xHzGjyANq4+UXBhvPuGgqsjOiXwFzmk@public.gmane.org>
2016-02-12 23:19 ` Jason Gunthorpe
[not found] ` <201602122223.u1CMNKL2004615@d03av02.boulder.ibm.com>
[not found] ` <201602122223.u1CMNKL2004615-nNA/7dmquNI+UXBhvPuGgqsjOiXwFzmk@public.gmane.org>
2016-02-12 22:46 ` Jason Gunthorpe
[not found] ` <20160212224642.GA4781-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-12 23:14 ` Stefan Berger
[not found] ` <201602122314.u1CNEk6P028695@d01av01.pok.ibm.com>
[not found] ` <201602122314.u1CNEk6P028695-4ZtxiNBBw+3ImUpY6SP3GEEOCMrvLtNR@public.gmane.org>
2016-02-12 23:21 ` Jason Gunthorpe
[not found] ` <201602091745.u19HjeEv001740@d03av02.boulder.ibm.com>
[not found] ` <201602091745.u19HjeEv001740-nNA/7dmquNI+UXBhvPuGgqsjOiXwFzmk@public.gmane.org>
2016-02-09 18:01 ` Jason Gunthorpe
[not found] ` <20160209180152.GA17475-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-09 18:11 ` Stefan Berger
[not found] ` <201602091812.u19ICTww018943@d03av01.boulder.ibm.com>
[not found] ` <201602091812.u19ICTww018943-Rn83F4s8Lwc+UXBhvPuGgqsjOiXwFzmk@public.gmane.org>
2016-02-09 18:20 ` Jason Gunthorpe
[not found] ` <20160209182013.GA19018-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-09 19:22 ` Stefan Berger
[not found] ` <201602091922.u19JMQ6r025254@d03av05.boulder.ibm.com>
[not found] ` <201602091922.u19JMQ6r025254-3MP/CPU4Muo+UXBhvPuGgqsjOiXwFzmk@public.gmane.org>
2016-02-09 19:36 ` Jason Gunthorpe
2016-02-08 19:27 ` [PATCH v5 5/5] A test program for vTPM device creation Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454959628-30582-5-git-send-email-stefanb@linux.vnet.ibm.com \
--to=stefanb-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
--cc=dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).