tpmdd-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: Nayna Jain <nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: [PATCH v5 0/7] tpm: cleanup/fixes in existing event log support
Date: Tue, 18 Oct 2016 20:49:38 -0400	[thread overview]
Message-ID: <1476838185-24007-1-git-send-email-nayna@linux.vnet.ibm.com> (raw)

This patch set includes the cleanup and bug fixes patches, previously
part of the "tpm: add the securityfs pseudo files support for TPM 2.0
firmware event log" patch set, in order to upstream them more quickly.

Changelog History

v5:

- Moved cleanup/fixes patches into this patch set.
- Patch "fix the race condition between event log access and chip
getting unregistered"
  - updated subject line and commit description.
  - modified fops code to use chip kref.
  - modified fops to lock inode before accessing inode private data.
  - renamed tpm_securityfs_data to tpm_chip_seqops, as it no more
    holds bios log, but associates seqops with respective chip. For
    the same reason, moved it to tpm.h
- Patch "replace or remove printk error messages"
  - cleaned up dev_dbg and used dev_info as applicable.

v4:

- Includes feedbacks from Jarkko and Jason.
- Patch "tpm: define a generic open() method for ascii & bios
measurements".
  - Fix indentation issue.
- Patch "tpm: replace the dynamically allocated bios_dir as
struct dentry array".
  - Continue to use bios_dir_count variable to use is_bad() checks and
    to maintain correct order for securityfs_remove() during teardown.
  - Reset chip->bios_dir_count in teardown() function.
- Patch "tpm: validate the event log access before tpm_bios_log_setup".
  - Retain TPM2 check which was removed in previous patch.
  - Add tpm_bios_log_setup failure handling.
  - Remove use of private data from v3 version of patch. Add a new
  member to struct tpm_chip to achieve the same purpose.
- Patch "tpm: redefine the read_log method to check for ACPI/OF 
properties sequentially".
  - Move replacement of CONFIG_TCG_IBMVTPM with CONFIG_OF to
  this patch from patch 3.
  - Replace -1 error code with -ENODEV.
- Patch "tpm: replace the of_find_node_by_name() with dev of_node
property".
  - Uses chip->dev.parent->of_node.
  - Created separate patch for cleanup of pr_err 
  messages.
- Patch "tpm: remove printk error messages".
  - New Patch.
- Patch "tpm: add the securityfs file support for TPM 2.0 event log".
  - Parses event digests using event alg_id rather than event log header
    alg_id.
  - Uses of_property_match_string to differentiate tpm/vtpm compatible
    property.
  - Adds the comment for difference in tpm/vtpm endianness.

v3:

- Includes the review feedbacks as suggested by Jason.
- Split of patches into one patch per idea.
- Generic open() method for ascii/bios measurements.
- Replacement of of **bios_dir with *bios_dir[3].
- Verifying readlog() is successful before creating securityfs entries.
- Generic readlog() to check for ACPI/OF in sequence.
- read_log_of() method now uses of_node propertry rather than
  calling find_device_by_name.
- read_log differentiates vtpm/tpm using its compatible property.
- Cleans pr_err with dev_dbg.
- Commit msgs subject line prefixed with tpm.

v2:

- Fixes issues as given in feedback by Jason.
- Adds documentation for device tree.

Jarkko Sakkinen (2):
  tpm: replace dynamically allocated bios_dir with a static array
  tpm: drop tpm1_chip_register(/unregister)

Nayna Jain (5):
  tpm: define a generic open() method for ascii & bios measurements
  tpm: fix the race condition between event log access and chip getting
    unregistered
  tpm: redefine read_log() to handle ACPI/OF at runtime
  tpm: replace of_find_node_by_name() with dev of_node property
  tpm: replace or remove printk error messages

 drivers/char/tpm/Makefile       |  14 +--
 drivers/char/tpm/tpm-chip.c     |  31 ++----
 drivers/char/tpm/tpm-sysfs.c    |   3 +
 drivers/char/tpm/tpm.h          |  14 ++-
 drivers/char/tpm/tpm_acpi.c     |  36 +++----
 drivers/char/tpm/tpm_eventlog.c | 208 ++++++++++++++++++++--------------------
 drivers/char/tpm/tpm_eventlog.h |  22 +++--
 drivers/char/tpm/tpm_of.c       |  46 ++++-----
 8 files changed, 176 insertions(+), 198 deletions(-)

-- 
2.5.0


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot

             reply	other threads:[~2016-10-19  0:49 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-19  0:49 Nayna Jain [this message]
     [not found] ` <1476838185-24007-1-git-send-email-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-10-19  0:49   ` [PATCH v5 1/7] tpm: define a generic open() method for ascii & bios measurements Nayna Jain
     [not found]     ` <1476838185-24007-2-git-send-email-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-11-02 10:36       ` Jarkko Sakkinen
2016-10-19  0:49   ` [PATCH v5 2/7] tpm: replace dynamically allocated bios_dir with a static array Nayna Jain
2016-10-19  0:49   ` [PATCH v5 3/7] tpm: drop tpm1_chip_register(/unregister) Nayna Jain
2016-10-19  0:49   ` [PATCH v5 4/7] tpm: fix the race condition between event log access and chip getting unregistered Nayna Jain
     [not found]     ` <1476838185-24007-5-git-send-email-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-10-19 16:13       ` Jarkko Sakkinen
2016-10-20 20:28       ` Jason Gunthorpe
2016-11-04  5:14       ` Jarkko Sakkinen
     [not found]         ` <20161104051410.iqxb5k6fwizv7inc-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-11-07 23:48           ` Jason Gunthorpe
     [not found]             ` <20161107234839.GC7002-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-11-08  0:26               ` Jarkko Sakkinen
     [not found]                 ` <20161108002642.4pvvubjcz57m4nov-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-11-08  0:29                   ` Jason Gunthorpe
     [not found]                     ` <20161108002943.GB13959-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-11-08  0:48                       ` Jarkko Sakkinen
2016-11-08  0:34                   ` Jarkko Sakkinen
2016-10-19  0:49   ` [PATCH v5 5/7] tpm: redefine read_log() to handle ACPI/OF at runtime Nayna Jain
     [not found]     ` <1476838185-24007-6-git-send-email-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-10-19 16:17       ` Jarkko Sakkinen
     [not found]         ` <20161019161739.ium2peamjwarpb5d-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-19 17:26           ` Jason Gunthorpe
     [not found]             ` <20161019172625.GC29879-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-10-20  7:17               ` Jarkko Sakkinen
2016-11-04  5:15       ` Jarkko Sakkinen
2016-10-19  0:49   ` [PATCH v5 6/7] tpm: replace of_find_node_by_name() with dev of_node property Nayna Jain
2016-10-19  0:49   ` [PATCH v5 7/7] tpm: replace or remove printk error messages Nayna Jain
     [not found]     ` <1476838185-24007-8-git-send-email-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-10-19 16:18       ` Jarkko Sakkinen
     [not found]         ` <20161019161854.iuzgacimusfcivvf-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-20  7:34           ` Winkler, Tomas
     [not found]             ` <5B8DA87D05A7694D9FA63FD143655C1B5430045A-Jy8z56yoSI8MvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-10-20 11:24               ` Jarkko Sakkinen
     [not found]                 ` <20161020112400.75pwp5ttk3yxuinq-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-21  3:22                   ` Nayna
     [not found]                     ` <580989E6.3060103-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-10-21 15:02                       ` Jarkko Sakkinen
     [not found]                         ` <20161021150250.24dyyi427rbnkpba-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-26  2:22                           ` Nayna
     [not found]                             ` <5810137D.2010002-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-10-26 10:56                               ` Jarkko Sakkinen
     [not found]                                 ` <20161026105649.kgav732btjfv4pfw-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-26 17:31                                   ` Nayna
     [not found]                                     ` <5810E854.3070905-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-10-27 13:53                                       ` Jarkko Sakkinen
     [not found]                                         ` <20161027135351.jndcn27xymgdgmux-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-27 15:05                                           ` Nayna
2016-10-20 13:31               ` Nayna
     [not found]                 ` <5808C747.4040709-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-10-20 13:43                   ` Jarkko Sakkinen
2016-11-04  5:18       ` Jarkko Sakkinen
2016-11-04 13:08   ` [PATCH v5 0/7] tpm: cleanup/fixes in existing event log support Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476838185-24007-1-git-send-email-nayna@linux.vnet.ibm.com \
    --to=nayna-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
    --cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).