tpmdd-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: Nayna Jain <nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: [PATCH v5 6/7] tpm: replace of_find_node_by_name() with dev of_node property
Date: Tue, 18 Oct 2016 20:49:44 -0400	[thread overview]
Message-ID: <1476838185-24007-7-git-send-email-nayna@linux.vnet.ibm.com> (raw)
In-Reply-To: <1476838185-24007-1-git-send-email-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>

Using the device of_node property is a better way to refer to the
device tree node rather than of_find_node_by_name().

Suggested-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Signed-off-by: Nayna Jain <nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
 drivers/char/tpm/tpm_of.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/char/tpm/tpm_of.c b/drivers/char/tpm/tpm_of.c
index 7c30752..22b8f81 100644
--- a/drivers/char/tpm/tpm_of.c
+++ b/drivers/char/tpm/tpm_of.c
@@ -29,7 +29,8 @@ int read_log_of(struct tpm_chip *chip)
 	struct tpm_bios_log *log;
 
 	log = &chip->log;
-	np = of_find_node_by_name(NULL, "vtpm");
+	if (chip->dev.parent->of_node)
+		np = chip->dev.parent->of_node;
 	if (!np) {
 		pr_err("%s: ERROR - IBMVTPM not supported\n", __func__);
 		return -ENODEV;
@@ -55,18 +56,15 @@ int read_log_of(struct tpm_chip *chip)
 	if (!log->bios_event_log) {
 		pr_err("%s: ERROR - Not enough memory for BIOS measurements\n",
 		       __func__);
-		of_node_put(np);
 		return -ENOMEM;
 	}
 
 	log->bios_event_log_end = log->bios_event_log + *sizep;
 
 	memcpy(log->bios_event_log, __va(*basep), *sizep);
-	of_node_put(np);
 
 	return 0;
 
 cleanup_eio:
-	of_node_put(np);
 	return -EIO;
 }
-- 
2.5.0


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot

  parent reply	other threads:[~2016-10-19  0:49 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-19  0:49 [PATCH v5 0/7] tpm: cleanup/fixes in existing event log support Nayna Jain
     [not found] ` <1476838185-24007-1-git-send-email-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-10-19  0:49   ` [PATCH v5 1/7] tpm: define a generic open() method for ascii & bios measurements Nayna Jain
     [not found]     ` <1476838185-24007-2-git-send-email-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-11-02 10:36       ` Jarkko Sakkinen
2016-10-19  0:49   ` [PATCH v5 2/7] tpm: replace dynamically allocated bios_dir with a static array Nayna Jain
2016-10-19  0:49   ` [PATCH v5 3/7] tpm: drop tpm1_chip_register(/unregister) Nayna Jain
2016-10-19  0:49   ` [PATCH v5 4/7] tpm: fix the race condition between event log access and chip getting unregistered Nayna Jain
     [not found]     ` <1476838185-24007-5-git-send-email-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-10-19 16:13       ` Jarkko Sakkinen
2016-10-20 20:28       ` Jason Gunthorpe
2016-11-04  5:14       ` Jarkko Sakkinen
     [not found]         ` <20161104051410.iqxb5k6fwizv7inc-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-11-07 23:48           ` Jason Gunthorpe
     [not found]             ` <20161107234839.GC7002-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-11-08  0:26               ` Jarkko Sakkinen
     [not found]                 ` <20161108002642.4pvvubjcz57m4nov-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-11-08  0:29                   ` Jason Gunthorpe
     [not found]                     ` <20161108002943.GB13959-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-11-08  0:48                       ` Jarkko Sakkinen
2016-11-08  0:34                   ` Jarkko Sakkinen
2016-10-19  0:49   ` [PATCH v5 5/7] tpm: redefine read_log() to handle ACPI/OF at runtime Nayna Jain
     [not found]     ` <1476838185-24007-6-git-send-email-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-10-19 16:17       ` Jarkko Sakkinen
     [not found]         ` <20161019161739.ium2peamjwarpb5d-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-19 17:26           ` Jason Gunthorpe
     [not found]             ` <20161019172625.GC29879-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-10-20  7:17               ` Jarkko Sakkinen
2016-11-04  5:15       ` Jarkko Sakkinen
2016-10-19  0:49   ` Nayna Jain [this message]
2016-10-19  0:49   ` [PATCH v5 7/7] tpm: replace or remove printk error messages Nayna Jain
     [not found]     ` <1476838185-24007-8-git-send-email-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-10-19 16:18       ` Jarkko Sakkinen
     [not found]         ` <20161019161854.iuzgacimusfcivvf-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-20  7:34           ` Winkler, Tomas
     [not found]             ` <5B8DA87D05A7694D9FA63FD143655C1B5430045A-Jy8z56yoSI8MvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-10-20 11:24               ` Jarkko Sakkinen
     [not found]                 ` <20161020112400.75pwp5ttk3yxuinq-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-21  3:22                   ` Nayna
     [not found]                     ` <580989E6.3060103-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-10-21 15:02                       ` Jarkko Sakkinen
     [not found]                         ` <20161021150250.24dyyi427rbnkpba-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-26  2:22                           ` Nayna
     [not found]                             ` <5810137D.2010002-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-10-26 10:56                               ` Jarkko Sakkinen
     [not found]                                 ` <20161026105649.kgav732btjfv4pfw-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-26 17:31                                   ` Nayna
     [not found]                                     ` <5810E854.3070905-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-10-27 13:53                                       ` Jarkko Sakkinen
     [not found]                                         ` <20161027135351.jndcn27xymgdgmux-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-27 15:05                                           ` Nayna
2016-10-20 13:31               ` Nayna
     [not found]                 ` <5808C747.4040709-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-10-20 13:43                   ` Jarkko Sakkinen
2016-11-04  5:18       ` Jarkko Sakkinen
2016-11-04 13:08   ` [PATCH v5 0/7] tpm: cleanup/fixes in existing event log support Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476838185-24007-7-git-send-email-nayna@linux.vnet.ibm.com \
    --to=nayna-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
    --cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).