From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mimi Zohar Subject: Re: [PATCH] tpm: Fix expected number of response bytes of TPM1.2 PCR Extend Date: Fri, 17 Feb 2017 13:48:38 -0500 Message-ID: <1487357318.15611.68.camel@linux.vnet.ibm.com> References: <1487177783-15687-1-git-send-email-stefanb@linux.vnet.ibm.com> <20170215180903.3simazptqnlhbqi6@intel.com> <1487335598.15611.9.camel@linux.vnet.ibm.com> <20170217184546.ik2vv5bleahqhkwv@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170217184546.ik2vv5bleahqhkwv-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jarkko Sakkinen Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, James Morris List-Id: tpmdd-devel@lists.sourceforge.net On Fri, 2017-02-17 at 20:45 +0200, Jarkko Sakkinen wrote: > On Fri, Feb 17, 2017 at 07:46:38AM -0500, Mimi Zohar wrote: > > Hi James, > > > > On Wed, 2017-02-15 at 20:09 +0200, Jarkko Sakkinen wrote: > > > On Wed, Feb 15, 2017 at 11:56:23AM -0500, Stefan Berger wrote: > > > > The TPM1.2 PCR Extend operation only returns 20 bytes in the body, > > > > which is the size of the PCR state. > > > > > > > > This fixes a problem where IMA gets errors with every PCR Extend. > > > > > > > > Fixes: c659af78eb7b ("tpm: Check size of response before accessing data") > > > > Signed-off-by: Stefan Berger > > > > Acked-by: Mimi Zohar > > > > > > Reviewed-by: Jarkko Sakkinen > > > > This patch needs to be included with the rest of the patches being > > upstreamed in the next open window. Should Jarkko or I send you a pull > > request for it? > I'm sending a pull request after the weekend. It will contain > only a few small scoped fixes so wouldn't it be easiest if I > just include this to the pack? As long as it makes it into the James' pull request to Linus, that's fine. Mimi ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot