From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v3 2/7] tpm_tis: Disable interrupt auto probing on a per-device basis Date: Mon, 4 Jan 2016 11:24:42 -0700 Message-ID: <20160104182442.GC20016@obsidianresearch.com> References: <1450376600-6970-1-git-send-email-jgunthorpe@obsidianresearch.com> <1450376600-6970-3-git-send-email-jgunthorpe@obsidianresearch.com> <20160103172040.GB4155@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160103172040.GB4155-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jarkko Sakkinen Cc: Martin Wilck , tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= List-Id: tpmdd-devel@lists.sourceforge.net On Sun, Jan 03, 2016 at 07:20:40PM +0200, Jarkko Sakkinen wrote: > On Thu, Dec 17, 2015 at 11:23:15AM -0700, Jason Gunthorpe wrote: > > Instead of clearing the global interrupts flag when any device > > does not have an interrupt just pass -1 through tpm_info.irq. > > > > The only thing that asks for autoprobing is the force=1 path. > > Sorry for my ignorance but what does this patch help? Why interrupts > flag is not enough? It is wrong for a driver's probe function to change global state, and very wrong to change a module option. > > Signed-off-by: Jason Gunthorpe > > Tested-by: Wilck, Martin > > Tested-by: Jarkko Sakkinen > > Did I already give Tested-by's for this series (I did for those that > went into v4.5 pull request)? You said you tested the crb stuff, which is this series... Did you test something else? Jason ------------------------------------------------------------------------------