From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: About devm_ioremap_resource() Date: Wed, 3 Feb 2016 14:55:19 -0800 Message-ID: <20160203225519.GA8647@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org Cc: linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net Hi I have couple of concerns with tpm_crb changes made for 4.5: * I used devm_ioremap_nocache() to disable WB. This does not matter when one has ACPI start as it goes through SMM and caches are flushed. It might be a problem with a CRB start only TPM device. How does devm_ioremap_resource address this? * I'm a bit puzzled with that function. Why there exists ioremaps that do not add stuff to a resource tree and those that do? Maybe you have a deeper understanding in this area could enlighten me since you did the commit. Thanks! /Jarkko ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140