From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Jarkko Sakkinen
<jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: jethro-LmnypSVwBK6EVqv0pETR8A@public.gmane.org,
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: resource sanity fails on ioremap
Date: Thu, 4 Feb 2016 16:49:47 -0700 [thread overview]
Message-ID: <20160204234947.GA20269@obsidianresearch.com> (raw)
In-Reply-To: <20160203233701.GA10585-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Wed, Feb 03, 2016 at 03:37:01PM -0800, Jarkko Sakkinen wrote:
> Hi
>
> I've been investigating this bug:
>
> https://bugzilla.kernel.org/show_bug.cgi?id=111511
>
> In all the machines that I've tried tpm_crb this does not occur on 4.4
> kernel and still the ioremapped buffers do interleave. It looks as if
> something that is not tpm_crb added that memory area to iomem_resource
> because 4.4 driver uses ioremap_nocache() and does not add anything to
> the resource tree.
The error says the BIOS set the ACPI resource for MSFT0101:00 to
0xfed40000-0xfed4087f and then proceeded to say that the region
0xfed40040-0xfed4103f is one of the additional TPM resources.
Is this right?
priv->cca = crb_access(dev, priv, buf->control_address, 0x1000);
Where did 0x1000 come from?
Why not sizeof(crb_control_area) ?
Jason
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
next prev parent reply other threads:[~2016-02-04 23:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 23:37 resource sanity fails on ioremap Jarkko Sakkinen
[not found] ` <20160203233701.GA10585-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-04 23:49 ` Jason Gunthorpe [this message]
[not found] ` <20160204234947.GA20269-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-05 4:05 ` Jarkko Sakkinen
[not found] ` <20160205040500.GA7708-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-05 5:08 ` Jason Gunthorpe
[not found] ` <20160205050850.GA23820-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-05 16:47 ` Jarkko Sakkinen
[not found] ` <20160205164704.GA8112-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-05 17:42 ` Jason Gunthorpe
[not found] ` <20160205174258.GA29116-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-05 19:28 ` Jarkko Sakkinen
[not found] ` <20160205192857.GA23523-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-10 12:22 ` Jarkko Sakkinen
[not found] ` <20160210122227.GA31734-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-10 12:42 ` Jarkko Sakkinen
[not found] ` <20160210124216.GA18392-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-10 16:02 ` Jason Gunthorpe
[not found] ` <20160210160238.GA20730-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-11 6:39 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160204234947.GA20269@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=jethro-LmnypSVwBK6EVqv0pETR8A@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).