From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH v5 4/5] Initialize TPM and get durations and timeouts Date: Thu, 11 Feb 2016 09:04:26 +0200 Message-ID: <20160211070426.GB9307@intel.com> References: <1454959628-30582-5-git-send-email-stefanb@linux.vnet.ibm.com> <20160209053323.GD12657@obsidianresearch.com> <201602091626.u19GQpga021574@d01av02.pok.ibm.com> <20160209165228.GA14611@obsidianresearch.com> <20160210035620.GB7161@intel.com> <201602100515.u1A5FpFi002736@d03av02.boulder.ibm.com> <20160210162809.GB20730@obsidianresearch.com> <201602102145.u1ALjSAs001597@d03av04.boulder.ibm.com> <20160210222313.GA7047@obsidianresearch.com> <201602110038.u1B0cuE0030670@d03av05.boulder.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <201602110038.u1B0cuE0030670-3MP/CPU4Muo+UXBhvPuGgqsjOiXwFzmk@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Stefan Berger Cc: dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Wed, Feb 10, 2016 at 07:38:52PM -0500, Stefan Berger wrote: > Jason Gunthorpe wrote on 02/10/2016 > 05:23:13 PM: > > > > > > > > > We shouldn't artificially limit the number of devices if > > > > virtualization is the target. Use an idr, or figure out how to > get rid > > > > of it. Since it is only used here: > > > > > > > > dev_set_name(&vtpm_dev->dev, "vtpms%d", vtpm_dev->dev_num); > > > > > > > > Maybe it could be adjusted to use chip->dev_num instead. > > > > > The chip->dev_num comes back from tpmm_chip_alloc() which is called > > > with the device as a parameter. That's the device we're trying to > > > > Hm, that is only needed for devm, could also do the tpm/tpmm split and > > avoid needing a registered dev. > > > > How about another patch on top of the ones I have so far only solving this > problem ? IDR has been on my backlog for a long time (over a year now). If you'd create a patch that would migrate the subsystem to that and do also do this split, I could take that patch as an independent contribution and you would have a better baseline to develop on top of. What do you think? /Jarkko ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140