From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH 1/3] tpm: Hold the kref during tpm_chip_find_get Date: Sun, 14 Feb 2016 06:55:12 +0200 Message-ID: <20160214045512.GA7777@intel.com> References: <1455321871-28296-1-git-send-email-jgunthorpe@obsidianresearch.com> <1455321871-28296-2-git-send-email-jgunthorpe@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1455321871-28296-2-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jason Gunthorpe Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Fri, Feb 12, 2016 at 05:04:29PM -0700, Jason Gunthorpe wrote: > This was missed during the struct device conversion, we > need to hold a kref on the chip to make sure it isn't freed. > > Signed-off-by: Jason Gunthorpe I'm bit confused about this patch. What is the regression if this needs to be dropped from my last pull request for 4.5 (that is the only one I'm planning to include from this patch set, rest are definitely post-4.5)? If there is clear regression in this patch, I can do it. I didn't reproduce any. /Jarkko > --- > drivers/char/tpm/tpm-chip.c | 2 ++ > drivers/char/tpm/tpm.h | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c > index 45cc39aabeee..ae2fed8a162b 100644 > --- a/drivers/char/tpm/tpm-chip.c > +++ b/drivers/char/tpm/tpm-chip.c > @@ -53,6 +53,8 @@ struct tpm_chip *tpm_chip_find_get(int chip_num) > chip = pos; > break; > } > + > + get_device(&chip->dev); > } > rcu_read_unlock(); > return chip; > diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h > index 542a80cbfd9c..f6ba79d91857 100644 > --- a/drivers/char/tpm/tpm.h > +++ b/drivers/char/tpm/tpm.h > @@ -207,6 +207,7 @@ struct tpm_chip { > static inline void tpm_chip_put(struct tpm_chip *chip) > { > module_put(chip->pdev->driver->owner); > + put_device(&chip->dev); > } > > static inline int tpm_read_index(int base, int index) > -- > 2.1.4 > ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140