tpmdd-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Jarkko Sakkinen
	<jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/3] tpm: Get rid of chip->pdev
Date: Sat, 13 Feb 2016 23:57:24 -0700	[thread overview]
Message-ID: <20160214065724.GD9551@obsidianresearch.com> (raw)
In-Reply-To: <20160214052414.GB8065-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

On Sun, Feb 14, 2016 at 07:24:14AM +0200, Jarkko Sakkinen wrote:
> > This should take care of it for all drivers including vtpm.
> > 
> > https://github.com/jgunthorpe/linux/commits/for-jarkko
> > 
> > At the very least this turns silent use after free into a null pointer
> > oops.
> > 
> > We should also discuss if we want to continue to have the driver
> > module locked while /dev/tpmX is open, that is no longer needed for
> > corectness.
> 
> I'm happy the patch that was sent before although I didn't give it
> Reviewed-by because it had couple of style errors. If those two
> style errors are the *only* issues I can fix up them.

This patch replaces the get/put_device patch entirely, if Stefan is
happy with it we can just go ahead in this direction for 4.6

There was also a 0day build error on the devname patch, so the whole
series will be reposted.

Jason

------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140

  parent reply	other threads:[~2016-02-14  6:57 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-13  0:04 [PATCH 0/3] Various struct device cleanups Jason Gunthorpe
     [not found] ` <1455321871-28296-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-13  0:04   ` [PATCH 1/3] tpm: Hold the kref during tpm_chip_find_get Jason Gunthorpe
     [not found]     ` <1455321871-28296-2-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-13 10:08       ` Jarkko Sakkinen
     [not found]         ` <20160213100818.GA12607-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-13 15:45           ` Jason Gunthorpe
2016-02-14  4:55       ` Jarkko Sakkinen
     [not found]         ` <20160214045512.GA7777-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-14  6:50           ` Jason Gunthorpe
2016-02-14  8:02             ` Jarkko Sakkinen
2016-02-13  0:04   ` [PATCH 2/3] tpm: Get rid of chip->pdev Jason Gunthorpe
     [not found]     ` <201602130037.u1D0bDEN029756@d01av04.pok.ibm.com>
2016-02-13  1:11       ` Jason Gunthorpe
     [not found]         ` <20160213011130.GA2547-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-13  1:31           ` Stefan Berger
     [not found]         ` <201602130128.u1D1S2Xn006955@d01av05.pok.ibm.com>
     [not found]           ` <201602130128.u1D1S2Xn006955-8DuMPbUlb4HImUpY6SP3GEEOCMrvLtNR@public.gmane.org>
2016-02-13  2:00             ` Jason Gunthorpe
2016-02-13  3:33             ` Jason Gunthorpe
2016-02-14  5:24               ` Jarkko Sakkinen
     [not found]                 ` <20160214052414.GB8065-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-14  6:57                   ` Jason Gunthorpe [this message]
     [not found]                     ` <20160214065724.GD9551-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-14  8:03                       ` Jarkko Sakkinen
     [not found]     ` <1455321871-28296-3-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-13  0:37       ` Stefan Berger
2016-02-13 15:39       ` Stefan Berger
     [not found]         ` <56BF4E1F.2030208-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-02-14  7:06           ` Jason Gunthorpe
2016-02-14  5:13       ` Jarkko Sakkinen
2016-02-13  0:04 ` [PATCH 3/3] tpm: Get rid of devname Jason Gunthorpe
     [not found]   ` <1455321871-28296-4-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-13  1:01     ` kbuild test robot
     [not found]       ` <201602130853.47ON3KAx%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-13  1:13         ` Jason Gunthorpe
2016-02-14  5:16     ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160214065724.GD9551@obsidianresearch.com \
    --to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
    --cc=jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).