From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v5 4/5] Initialize TPM and get durations and timeouts Date: Tue, 16 Feb 2016 11:00:28 -0700 Message-ID: <20160216180028.GA4967@obsidianresearch.com> References: <20160211194810.GA24211@obsidianresearch.com> <201602112210.u1BMAYPe015452@d03av01.boulder.ibm.com> <20160211221822.GA16304@obsidianresearch.com> <201602112226.u1BMQZ59031657@d01av02.pok.ibm.com> <20160211235611.GB16304@obsidianresearch.com> <201602120356.u1C3usEe002034@d03av04.boulder.ibm.com> <201602121813.u1CIDu4O015272@d01av01.pok.ibm.com> <20160212183415.GA4289@obsidianresearch.com> <201602140637.u1E6baNX028563@d03av04.boulder.ibm.com> <201602161648.u1GGmdZv000468@d01av03.pok.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <201602161648.u1GGmdZv000468-CUdSWdNILC7ImUpY6SP3GEEOCMrvLtNR@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Stefan Berger Cc: dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Tue, Feb 16, 2016 at 11:44:06AM -0500, Stefan Berger wrote: > Scratch that. The easier way to fix this was to release the tpm_chip > after the vtpm_dev. Right, that is nicer Did you solve the lock ups when register fails? One other thing you can look at is ditching the vtpm struct device. With the last patches I sent the tpm core would only need two more lines to work with a null parent device, which would be even simpler for vtpm. Jason ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140