From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] tpm_crb: fix bad name pointer usage with struct resource
Date: Wed, 17 Feb 2016 11:36:23 +0200 [thread overview]
Message-ID: <20160217093623.GA9831@intel.com> (raw)
In-Reply-To: <20160217045219.GA26086-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
On Tue, Feb 16, 2016 at 09:52:19PM -0700, Jason Gunthorpe wrote:
> On Wed, Feb 17, 2016 at 02:27:54AM +0200, Jarkko Sakkinen wrote:
> > - if (acpi_dev_resource_memory(ares, &res))
> > + if (acpi_dev_resource_memory(ares, &res)) {
> > + res.name = NULL;
>
> What? How is this not a bug in acpi_dev_resource_memory? Maybe it
> needs to memcpy into devm allocated memory instead, but I'm confused
> how/why/when acpi could free name.
>
> The same code exists in tpm_tis as well.
That was the only way to fix the garbage issue. I would keep things
this way for Linux 4.5.
/Jarkko
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
next prev parent reply other threads:[~2016-02-17 9:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 0:27 [PATCH] tpm_crb: fix bad name pointer usage with struct resource Jarkko Sakkinen
[not found] ` <1455668874-13261-1-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-02-17 4:52 ` Jason Gunthorpe
[not found] ` <20160217045219.GA26086-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-17 9:36 ` Jarkko Sakkinen [this message]
[not found] ` <20160217093623.GA9831-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-17 14:20 ` Jarkko Sakkinen
[not found] ` <20160217142016.GA6951-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-18 17:31 ` Jason Gunthorpe
2016-02-19 15:06 ` [tpmdd-devel] " Jarkko Sakkinen
[not found] ` <20160219150606.GB7474-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-19 17:44 ` Jason Gunthorpe
2016-02-20 8:04 ` [tpmdd-devel] " Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217093623.GA9831@intel.com \
--to=jarkko.sakkinen-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).