From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH] tpm_crb: fix: associate to the correct device Date: Thu, 18 Feb 2016 22:10:35 +0200 Message-ID: <20160218201035.GA7033@intel.com> References: <1455708211-9653-1-git-send-email-jarkko.sakkinen@linux.intel.com> <20160218180331.GA7191@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160218180331.GA7191-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jason Gunthorpe Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Thu, Feb 18, 2016 at 11:03:31AM -0700, Jason Gunthorpe wrote: > On Wed, Feb 17, 2016 at 01:23:31PM +0200, Jarkko Sakkinen wrote: > > At the moment for tpm_crb /proc/iomem shows the HW interface and not the > > device using the memory range. This patch fixes the issue by associating > > memory mappings to the TPM character device. > > > > The end result is this: > > > > $ cat /proc/iomem|grep MSFT -A2 > > dbfff000-dbffffff : MSFT0101:00 > > dbfff000-dbffffff : tpm0 > > Hmmm... This large patch basically changes devm_ioremap so it uses the > tpm chip dev not the acpi_dev - which seems reasonable - however I > notice lots of drivers do use the parent device.. > > However, it will change the unwind ordering on remove.. And when we > check if tpm_crb is OK on that point I see this bug: > > static int crb_acpi_remove(struct acpi_device *device) > { > [..] > tpm_chip_unregister(chip); > if (chip->flags & TPM_CHIP_FLAG_TPM2) > tpm2_shutdown(chip, TPM2_SU_CLEAR); Good catch, thanks! /Jarkko ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140