From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH 00/12] tpm/st33zp24: Few code style and sanity fixes + acpi device probing support Date: Fri, 19 Feb 2016 17:03:52 +0200 Message-ID: <20160219150352.GA7474@intel.com> References: <1455010021-21927-1-git-send-email-christophe-h.ricard@st.com> <20160214091106.GA18761@intel.com> <56C56EED.1070801@gmail.com> <20160218144651.GA8472@intel.com> <56C631A7.5040604@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <56C631A7.5040604-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Christophe Ricard Cc: jean-luc.blanc-qxv4g6HH51o@public.gmane.org, ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, christophe-h.ricard-qxv4g6HH51o@public.gmane.org, benoit.houyere-qxv4g6HH51o@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Thu, Feb 18, 2016 at 10:03:35PM +0100, Christophe Ricard wrote: > Hi Jarkko, > > Thanks for your feedback :) > > On 18/02/2016 15:46, Jarkko Sakkinen wrote: > >On Thu, Feb 18, 2016 at 08:12:45AM +0100, Christophe Ricard wrote: > >>Hi Jarkko, > >> > >>Do you expect anything more on this serie from me ? > >>Do you think it will reach 4.6 release ? > >Your first series (that you sent earlier than this) is going in 100% > >certainty. I'll review this as soon as possible. > Just to save your time and to be a bit more precise on the cover-letter, > The only change in v2 serie (the latest) bring a small fix in PATCH 12: > ... > > - ret = st33zp24_spi_acpi_request_resources(phy); > + ret = st33zp24_spi_acpi_request_resources(dev); ... OK thanks! I can do this change. /Jarkko > > >The problem has been that there was a latency to get my second pull > >request for 4.5 and I still have some fixes that we need for that > >release (and need to send a pull request). > No problem on my side. I understand i will wait. > > Best Regards > Christophe > >>Best Regards > >>Christophe > >/Jarkko > > > >> > >>On 14/02/2016 10:11, Jarkko Sakkinen wrote: > >>>On Tue, Feb 09, 2016 at 10:26:49AM +0100, Christophe Ricard wrote: > >>>>Hi Peter, Jarko, > >>>> > >>>>Please find in the following serie: > >>>>- a set of code style or sanity cleanup > >>>>- acpi device probing support for i2c and spi phys. > >>>How big coverage could I get to these patches if I tested them with a > >>>Minnowboard? > >>> > >>>/Jarkko > >>> > >>>>This serie applies on top of jarkko tree: > >>>>b64f343cb02b2a2a009b3805a8331425dd4a8611 tpm: fix rollback/cleanup before tpm_chip_register() > >>>> > >>>>Best Regards > >>>>Christophe > >>>> > >>>>Christophe Ricard (12): > >>>> tpm/st33zp24/spi: Remove nbr_dummy_bytes variable usage > >>>> tpm/st33zp24/spi: Use functions name with st33zp24_spi_ prefix > >>>> tpm/st33zp24/spi: Remove useless use of memcpy. > >>>> tpm/st33zp24/spi: Remove field spi_xfer from st33zp24_spi_phy > >>>> structure > >>>> tpm/st33zp24: Remove unneeded CONFIG_OF switches > >>>> tpm/st33zp24: Auto-select core module > >>>> tpm/st33zp24/spi: Improve st33zp24_spi_evaluate_latency > >>>> tpm/st33zp24: Extend Copyright headers > >>>> tpm/st33zp24: Add support for acpi probing for i2c device. > >>>> tpm: st33zp24: Add support for acpi probing for spi device. > >>>> tpm/st33zp24/i2c: Change xxx_request_resources header > >>>> tpm/st33zp24/spi: Change xxx_request_resources header > >>>> > >>>> drivers/char/tpm/st33zp24/Kconfig | 11 +- > >>>> drivers/char/tpm/st33zp24/i2c.c | 76 ++++++++++--- > >>>> drivers/char/tpm/st33zp24/spi.c | 190 ++++++++++++++++++++------------- > >>>> drivers/char/tpm/st33zp24/st33zp24.c | 2 +- > >>>> drivers/char/tpm/st33zp24/st33zp24.h | 2 +- > >>>> include/linux/platform_data/st33zp24.h | 2 +- > >>>> 6 files changed, 182 insertions(+), 101 deletions(-) > >>>> > >>>>-- > >>>>2.5.0 > >>>> > ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140