From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: James Morris <jmorris@namei.org>,
linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
linux-kernel@vger.kernel.org, tpmdd-devel@lists.sourceforge.net,
Wilck@intel.com, Martin <martin.wilck@ts.fujitsu.com>
Subject: Re: [GIT PULL] remaining tpmdd fixes for Linux 4.5
Date: Mon, 22 Feb 2016 21:08:28 +0200 [thread overview]
Message-ID: <20160222190828.GA32231@intel.com> (raw)
In-Reply-To: <20160222175245.GA22828@obsidianresearch.com>
On Mon, Feb 22, 2016 at 10:52:45AM -0700, Jason Gunthorpe wrote:
> On Mon, Feb 22, 2016 at 04:50:23PM +0200, Jarkko Sakkinen wrote:
>
> > I already pushed a fix to my master for this issue:
> >
> > https://github.com/jsakkine/linux-tpmdd/commit/6386544ad7bceb3d0248b85da29d4d99eebe9161
>
> The goal is to reduce the number of #ifdef'd code segments so we have
> fewer problems in future with a large .config test matrix.
>
> I'd rather see a __maybe_unused annotation instead.
Agreed that it's a better form but at this point it's probably revert
the breaking change and move to that later on. Otherwise, I don't see
reason not to include the patch that you authored to the release. I've
used it in my test kernels for quite some time now and it has worked
without issues.
I sent my fix for review now.
> Jason
/Jarkko
next prev parent reply other threads:[~2016-02-22 19:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-20 8:17 [GIT PULL] remaining tpmdd fixes for Linux 4.5 Jarkko Sakkinen
[not found] ` <20160220081705.GA12981-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-22 1:56 ` James Morris
[not found] ` <alpine.LRH.2.20.1602221255210.4918-gx6/JNMH7DfYtjvyW6yDsg@public.gmane.org>
2016-02-22 14:50 ` Jarkko Sakkinen
[not found] ` <20160222145023.GA28365-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-22 17:52 ` Jason Gunthorpe
2016-02-22 19:08 ` Jarkko Sakkinen [this message]
2016-02-22 19:11 ` Jason Gunthorpe
2016-02-22 21:23 ` Jarkko Sakkinen
2016-02-25 17:30 ` Jerry Snitselaar
[not found] ` <20160225173044.gcr2j65ihv6cevzm-8w2GRY7Bv7UXGNroddHbYwC/G2K4zDHf@public.gmane.org>
2016-02-26 3:38 ` James Morris
[not found] ` <alpine.LRH.2.20.1602261438340.17858-gx6/JNMH7DfYtjvyW6yDsg@public.gmane.org>
2016-02-26 9:48 ` Jarkko Sakkinen
2016-02-26 7:57 ` James Morris
[not found] ` <alpine.LRH.2.20.1602261857040.28734-gx6/JNMH7DfYtjvyW6yDsg@public.gmane.org>
2016-02-26 9:00 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160222190828.GA32231@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=Wilck@intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=martin.wilck@ts.fujitsu.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).