From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v3 09/11] tpm: Driver for supporting multiple emulated TPMs Date: Mon, 22 Feb 2016 12:27:41 -0700 Message-ID: <20160222192741.GI22088@obsidianresearch.com> References: <1455885728-10315-1-git-send-email-stefanb@linux.vnet.ibm.com> <1455885728-10315-10-git-send-email-stefanb@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1455885728-10315-10-git-send-email-stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Stefan Berger Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Fri, Feb 19, 2016 at 07:42:06AM -0500, Stefan Berger wrote: > +#define VTPM_NUM_DEVICES TPM_NUM_DEVICES Never used > + rc = copy_to_user(buf, vtpm_dev->buffer, len); > + memset(vtpm_dev->buffer, 0, len); > + vtpm_dev->req_len = 0; > + > + spin_unlock(&vtpm_dev->buf_lock); No, do not call copy_to_user in a spin lock, (or copy_from_user) > + chip->vendor.irq = 1; Do not set this, I am trying to remove it.. Overall, I think everything has turned out very nice indeed. Jason ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140