From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v3 03/11] tpm: Get rid of devname Date: Mon, 22 Feb 2016 13:34:27 -0700 Message-ID: <20160222203427.GA26909@obsidianresearch.com> References: <1455885728-10315-1-git-send-email-stefanb@linux.vnet.ibm.com> <1455885728-10315-4-git-send-email-stefanb@linux.vnet.ibm.com> <20160222181929.GB22088@obsidianresearch.com> <20160222194202.GC32667@intel.com> <20160222195816.GL22088@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160222195816.GL22088-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jarkko Sakkinen Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Mon, Feb 22, 2016 at 12:58:16PM -0700, Jason Gunthorpe wrote: > On Mon, Feb 22, 2016 at 09:42:02PM +0200, Jarkko Sakkinen wrote: > > > Oops, something went wrong here in all the rebasing - dev_set_name has > > > to be after devince_initialize. > > > > Why dev_set_name() cannot be called before device_initialize(). I see > > many drivers call it before device_register() like RTC driver just as > > an example: > > Yep, you are right, it still looks nicer with the init earlier, but > the later patch does that anyhow. Sorry, to be clear, the dev_set_name is OK, but the error unwind for it in this patch is not OK, it requires device_initialize to have been called. The change should still be made.. Jason ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140