Re: [PATCH v3 06/11] tpm: Split out the devm stuff from tpmm_chip_alloc

[Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>]

On Mon, Feb 22, 2016 at 11:14:14PM +0200, Jarkko Sakkinen wrote:
> On Fri, Feb 19, 2016 at 07:42:03AM -0500, Stefan Berger wrote:
> > From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
> > 
> > tpm_chip_alloc becomes a typical subsystem allocate call.
> 
> Maybe a more verbose commit message?

What more do you want to say?

> >  	spin_lock(&driver_lock);
> >  	chip->dev_num = find_first_zero_bit(dev_mask, TPM_NUM_DEVICES);
> > +	if (chip->dev_num < TPM_NUM_DEVICES)
> > +		set_bit(chip->dev_num, dev_mask);
> 
> I guess this change should a separate patch.

Hurm, Stefan? This was not in the patch I sent you? This hunk looks
incomplete to me, and replaced by the IDR stuff anyhow. Drop it?

You need to put your Signed-off-by on patches you make notable changes
to, this one would qualify

Jason

------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140