From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v3 06/11] tpm: Split out the devm stuff from tpmm_chip_alloc Date: Mon, 22 Feb 2016 15:13:28 -0700 Message-ID: <20160222221328.GA27228@obsidianresearch.com> References: <1455885728-10315-1-git-send-email-stefanb@linux.vnet.ibm.com> <1455885728-10315-7-git-send-email-stefanb@linux.vnet.ibm.com> <20160222211414.GC3310@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160222211414.GC3310-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jarkko Sakkinen Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Mon, Feb 22, 2016 at 11:14:14PM +0200, Jarkko Sakkinen wrote: > On Fri, Feb 19, 2016 at 07:42:03AM -0500, Stefan Berger wrote: > > From: Jason Gunthorpe > > > > tpm_chip_alloc becomes a typical subsystem allocate call. > > Maybe a more verbose commit message? What more do you want to say? > > spin_lock(&driver_lock); > > chip->dev_num = find_first_zero_bit(dev_mask, TPM_NUM_DEVICES); > > + if (chip->dev_num < TPM_NUM_DEVICES) > > + set_bit(chip->dev_num, dev_mask); > > I guess this change should a separate patch. Hurm, Stefan? This was not in the patch I sent you? This hunk looks incomplete to me, and replaced by the IDR stuff anyhow. Drop it? You need to put your Signed-off-by on patches you make notable changes to, this one would qualify Jason ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140