From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Christophe Ricard
<christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: jean-luc.blanc-qxv4g6HH51o@public.gmane.org,
ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org,
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
christophe-h.ricard-qxv4g6HH51o@public.gmane.org,
benoit.houyere-qxv4g6HH51o@public.gmane.org
Subject: Re: [PATCH v2 00/12] tpm/st33zp24: Few code style and sanity fixes + acpi device probing support
Date: Tue, 23 Feb 2016 01:56:39 +0200 [thread overview]
Message-ID: <20160222235639.GA7721@intel.com> (raw)
In-Reply-To: <1455376535-9549-1-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
On Sat, Feb 13, 2016 at 04:15:23PM +0100, Christophe Ricard wrote:
> Hi Peter, Jarko,
>
> Please find in the following serie:
> - a set of code style or sanity cleanup
> - acpi device probing support for i2c and spi phys.
>
> In v2, i have:
> - Added Jarkko review
> - Fixed a warning on patch 12
>
> This serie applies on top of jarkko tree:
> b64f343cb02b2a2a009b3805a8331425dd4a8611 tpm: fix rollback/cleanup before tpm_chip_register()
I've now applied the patches to my master branch:
* All of them have my Reviewed-by. For one patch I had to fix one style
error (one line was of over 80 characters).
* Two of the patches have my Tested-by.
Now I'm trying to get a Minnowboard so that I could test ACPI probing
for I2C/SPI device. If that would work, then this seres would be ready
for a pull request.
Can you check quickly check the applied patches to make sure that I
didn't mess anything up? And perhaps compile my master and see if
things work at run-time as well?
> Best Regards
> Christophe
/Jarkko
>
> Christophe Ricard (12):
> tpm/st33zp24/spi: Remove nbr_dummy_bytes variable usage
> tpm/st33zp24/spi: Use functions name with st33zp24_spi_ prefix
> tpm/st33zp24/spi: Remove useless use of memcpy.
> tpm/st33zp24/spi: Remove field spi_xfer from st33zp24_spi_phy
> structure
> tpm/st33zp24: Remove unneeded CONFIG_OF switches
> tpm/st33zp24: Auto-select core module
> tpm/st33zp24/spi: Improve st33zp24_spi_evaluate_latency
> tpm/st33zp24: Extend Copyright headers
> tpm/st33zp24: Add support for acpi probing for i2c device.
> tpm: st33zp24: Add support for acpi probing for spi device.
> tpm/st33zp24/i2c: Change xxx_request_resources header
> tpm/st33zp24/spi: Change xxx_request_resources header
>
> drivers/char/tpm/st33zp24/Kconfig | 11 +-
> drivers/char/tpm/st33zp24/i2c.c | 76 ++++++++++---
> drivers/char/tpm/st33zp24/spi.c | 190 ++++++++++++++++++++-------------
> drivers/char/tpm/st33zp24/st33zp24.c | 2 +-
> drivers/char/tpm/st33zp24/st33zp24.h | 2 +-
> include/linux/platform_data/st33zp24.h | 2 +-
> 6 files changed, 182 insertions(+), 101 deletions(-)
>
> --
> 2.5.0
>
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
next prev parent reply other threads:[~2016-02-22 23:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-13 15:15 [PATCH v2 00/12] tpm/st33zp24: Few code style and sanity fixes + acpi device probing support Christophe Ricard
[not found] ` <1455376535-9549-1-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-02-13 15:15 ` [PATCH v2 01/12] tpm/st33zp24/spi: Remove nbr_dummy_bytes variable usage Christophe Ricard
2016-02-13 15:15 ` [PATCH v2 02/12] tpm/st33zp24/spi: Use functions name with st33zp24_spi_ prefix Christophe Ricard
2016-02-13 15:15 ` [PATCH v2 03/12] tpm/st33zp24/spi: Remove useless use of memcpy Christophe Ricard
2016-02-13 15:15 ` [PATCH v2 04/12] tpm/st33zp24/spi: Remove field spi_xfer from st33zp24_spi_phy structure Christophe Ricard
2016-02-13 15:15 ` [PATCH v2 05/12] tpm/st33zp24: Remove unneeded CONFIG_OF switches Christophe Ricard
2016-02-13 15:15 ` [PATCH v2 06/12] tpm/st33zp24: Auto-select core module Christophe Ricard
2016-02-13 15:15 ` [PATCH v2 07/12] tpm/st33zp24/spi: Improve st33zp24_spi_evaluate_latency Christophe Ricard
2016-02-13 15:15 ` [PATCH v2 08/12] tpm/st33zp24: Extend Copyright headers Christophe Ricard
2016-02-13 15:15 ` [PATCH v2 09/12] tpm/st33zp24: Add support for acpi probing for i2c device Christophe Ricard
2016-02-13 15:15 ` [PATCH v2 10/12] tpm: st33zp24: Add support for acpi probing for spi device Christophe Ricard
[not found] ` <1455376535-9549-11-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-02-22 15:57 ` Jarkko Sakkinen
2016-02-13 15:15 ` [PATCH v2 11/12] tpm/st33zp24/i2c: Change xxx_request_resources header Christophe Ricard
2016-02-13 15:15 ` [PATCH v2 12/12] tpm/st33zp24/spi: " Christophe Ricard
2016-02-22 23:56 ` Jarkko Sakkinen [this message]
[not found] ` <20160222235639.GA7721-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-25 7:48 ` [PATCH v2 00/12] tpm/st33zp24: Few code style and sanity fixes + acpi device probing support Christophe Ricard
[not found] ` <56CEB1DA.4020709-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-25 13:18 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160222235639.GA7721@intel.com \
--to=jarkko.sakkinen-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org \
--cc=benoit.houyere-qxv4g6HH51o@public.gmane.org \
--cc=christophe-h.ricard-qxv4g6HH51o@public.gmane.org \
--cc=christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jean-luc.blanc-qxv4g6HH51o@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).