From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Stefan Berger" Subject: Re: [PATCH v3 03/11] tpm: Get rid of devname Date: Mon, 22 Feb 2016 19:22:56 -0500 Message-ID: <201602230023.u1N0NO69020368@d03av05.boulder.ibm.com> References: <1455885728-10315-1-git-send-email-stefanb@linux.vnet.ibm.com><1455885728-10315-4-git-send-email-stefanb@linux.vnet.ibm.com> <20160222181929.GB22088@obsidianresearch.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8091002323149278748==" Return-path: In-Reply-To: <20160222181929.GB22088-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jason Gunthorpe Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net --===============8091002323149278748== Content-Type: multipart/alternative; boundary="=_alternative 0002223D85257F62_=" --=_alternative 0002223D85257F62_= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="US-ASCII" Jason Gunthorpe wrote on 02/22/2016=20 01:19:29 PM: > From: Jason Gunthorpe > To: Stefan Berger > Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org > Date: 02/22/2016 01:20 PM > Subject: Re: [tpmdd-devel] [PATCH v3 03/11] tpm: Get rid of devname >=20 > On Fri, Feb 19, 2016 at 07:42:00AM -0500, Stefan Berger wrote: > >=20 > > - dev=5Fset=5Fname(&chip->dev, "%s", chip->devname); > > + err =3D dev=5Fset=5Fname(&chip->dev, "tpm%d", chip->dev=5Fnum); > > + if (err) > > + goto out; > >=20 > > device=5Finitialize(&chip->dev); > >=20 > > @@ -142,6 +142,10 @@ struct tpm=5Fchip *tpmm=5Fchip=5Falloc(struct devi= ce=20 *dev, > > } > >=20 > > return chip; > > + > > +out: > > + put=5Fdevice(&chip->dev); > > + return ERR=5FPTR(err); >=20 > Oops, something went wrong here in all the rebasing - dev=5Fset=5Fname has > to be after devince=5Finitialize. dev=5Fset=5Fname is now after device=5Finitialize. Stefan --=_alternative 0002223D85257F62_= Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset="US-ASCII" Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> wrote on 02/22/2016 01:19:29 PM:

> From: Jason Gunthorpe <jgun= thorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
> To: = Stefan Berger <stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
> Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> Date: 02/22/2016 01:20 PM
= > Subject: Re: [tpmdd-devel] [PATCH v3 03/11] tpm: Get rid of devname
>
> On Fri, = Feb 19, 2016 at 07:42:00AM -0500, Stefan Berger wrote:
> >  <= br>> > -   dev=5Fset=5Fname(&chip->dev, "%s", c= hip->devname);
> > +   err =3D dev=5Fset=5Fname(&chip-= >dev, "tpm%d", chip->dev=5Fnum);
> > +   if (err)
> > +   &= nbsp;  goto out;
> >  
> >     device= =5Finitialize(&chip->dev);
> >  
> > @@ -142,= 6 +142,10 @@ struct tpm=5Fchip *tpmm=5Fchip=5Falloc(struct device *dev,
> >     }
> >  
> > =     return chip;
> > +
> > +out:
> > +=   put=5Fdevice(&chip->dev);
> > +   return ERR= =5FPTR(err);
>
> Oops, something went wrong here in all the re= basing - dev=5Fset=5Fname has
> to be after devince=5Finitialize.

dev=5Fset=5Fname is now after device=5Finitialize.
=
   Stefan

--=_alternative 0002223D85257F62_=-- --===============8091002323149278748== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 --===============8091002323149278748== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ tpmdd-devel mailing list tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/tpmdd-devel --===============8091002323149278748==--