From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH v4 03/10] tpm: Provide strong locking for device removal Date: Fri, 4 Mar 2016 20:10:38 +0200 Message-ID: <20160304181038.GA24462@intel.com> References: <1456766996-9300-1-git-send-email-stefanb@linux.vnet.ibm.com> <1456766996-9300-4-git-send-email-stefanb@linux.vnet.ibm.com> <20160229192532.GB15042@obsidianresearch.com> <201602291949.u1TJn2Av025592@d03av03.boulder.ibm.com> <20160229195400.GA32380@obsidianresearch.com> <201602292004.u1TK4IDH023664@d01av04.pok.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <201602292004.u1TK4IDH023664-YREtIfBy6dDImUpY6SP3GEEOCMrvLtNR@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Stefan Berger Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Mon, Feb 29, 2016 at 03:04:10PM -0500, Stefan Berger wrote: > Jason Gunthorpe wrote on 02/29/2016 > 02:54:01 PM: > > > > > On Mon, Feb 29, 2016 at 02:48:54PM -0500, Stefan Berger wrote: > > > Jason Gunthorpe wrote on > 02/29/2016 > > > 02:25:32 PM: > > > > > > > > On Mon, Feb 29, 2016 at 12:29:49PM -0500, Stefan Berger wrote: > > > > > * the device. As the last step this function adds the chip to > > > > the list of TPM > > > > > * chips available for in-kernel use. > > > > > * > > > > > + * Once this function returns the driver call backs in 'op's > will > > > not be > > > > > + * running and will no longer start. > > > > > + * > > > > > * This function should be only called after the chip > > > initialization is > > > > > * complete. > > > > > */ > > > > > > > > Not sure what happened here, but this hunk belongs with > > > > tpm_chip_unregister > > > That's where it is. The context 'tpm1_chip_unregister' the hunk > shows > > > is from the function 'above'. > > > > Eh? > > > > https://github.com/stefanberger/linux/blob/ > > > 63f0cd1bae930167d31bbe5d5779d40a277e91c5/drivers/char/tpm/tpm-chip.c#L311 > > Sorry. Fixed here : > https://github.com/stefanberger/linux/commit/5808cd0b01b00e1a4e3b23d6970bac4efee69038 Already applied v4. Could you send a fix for this to the list? Thanks. > Stefan /Jarkko ------------------------------------------------------------------------------