From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Stefan Berger" Subject: Re: [PATCH v4 03/10] tpm: Provide strong locking for device removal Date: Fri, 4 Mar 2016 14:06:23 -0500 Message-ID: <201603041908.u24J8JOi008138@d03av01.boulder.ibm.com> References: <1456766996-9300-1-git-send-email-stefanb@linux.vnet.ibm.com> <1456766996-9300-4-git-send-email-stefanb@linux.vnet.ibm.com> <20160229192532.GB15042@obsidianresearch.com> <201602291949.u1TJn2Av025592@d03av03.boulder.ibm.com> <20160229195400.GA32380@obsidianresearch.com> <201602292004.u1TK4IDH023664@d01av04.pok.ibm.com> <20160304181038.GA24462@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6849315132857821458==" Return-path: In-Reply-To: <20160304181038.GA24462-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jarkko Sakkinen Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net --===============6849315132857821458== Content-Type: multipart/alternative; boundary="=_alternative 0068F71F85257F6C_=" --=_alternative 0068F71F85257F6C_= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="US-ASCII" Jarkko Sakkinen wrote on 03/04/2016=20 01:10:38 PM: >=20 > On Mon, Feb 29, 2016 at 03:04:10PM -0500, Stefan Berger wrote: > > Jason Gunthorpe wrote on=20 02/29/2016 > > 02:54:01 PM: > >=20 > > > > > > On Mon, Feb 29, 2016 at 02:48:54PM -0500, Stefan Berger wrote: > > > > Jason Gunthorpe wrote on > > 02/29/2016 > > > > 02:25:32 PM: > > > > > > > > > > On Mon, Feb 29, 2016 at 12:29:49PM -0500, Stefan Berger=20 wrote: > > > > > > * the device. As the last step this function adds=20 > the chip to > > > > > the list of TPM > > > > > > * chips available for in-kernel use. > > > > > > * > > > > > > + * Once this function returns the driver call backs in=20 'op's > > will > > > > not be > > > > > > + * running and will no longer start. > > > > > > + * > > > > > > * This function should be only called after the chip > > > > initialization is > > > > > > * complete. > > > > > > */ > > > > > > > > > > Not sure what happened here, but this hunk belongs with > > > > > tpm=5Fchip=5Funregister > > > > That's where it is. The context 'tpm1=5Fchip=5Funregister' th= e=20 hunk > > shows > > > > is from the function 'above'. > > > > > > Eh? > > > > > > https://github.com/stefanberger/linux/blob/ > > > > >=20 63f0cd1bae930167d31bbe5d5779d40a277e91c5/drivers/char/tpm/tpm-chip.c#L311 > >=20 > > Sorry. Fixed here : > > https://github.com/stefanberger/linux/commit/ > 5808cd0b01b00e1a4e3b23d6970bac4efee69038 >=20 > Already applied v4. Could you send a fix for this to the list? > Thanks. I can post v5 that also has the Reviewed-by's applied. https://github.com/stefanberger/linux/commits/vtpm-driver.v5 Stefan >=20 > > Stefan >=20 > /Jarkko >=20 --=_alternative 0068F71F85257F6C_= Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset="US-ASCII" Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> wrote on 03/04/2016 01:10:38 PM:

>=
> On Mon, Feb 29, 2016 at 03:04:10PM -0500, Stefan Berger wrote:> >    Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org= > wrote on 02/29/2016
> >    02:54:01 PM:
> > > >    >
> >    > On Mon, Feb 29,= 2016 at 02:48:54PM -0500, Stefan Berger wrote:
> >    > >    Jason Guntho= rpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> wrote on
> >    02/29/2016
> >    >= ; >    02:25:32 PM:
> >    > >  =  >
> >    > >    > On Mon, F= eb 29, 2016 at 12:29:49PM -0500, Stefan Berger wrote:
> >    > &g= t;    > >   * the device. As the last step this function adds
> the chip to
> >  = ;  > >    > the list of TPM
> >   &nb= sp;> >    > >   * chips available for in-kernel use.
> >    > >   &nb= sp;> >   *
> >    > >    >= > + * Once this function returns the driver call backs in 'op's
> >    will
&g= t; >    > >    not be
> >   &nbs= p;> >    > > + * running and will no longer start.
> >    > >    >= > + *
> >    > >    > >  = * This function should be only called after the chip
> >    > > &n= bsp;  initialization is
> >    > >   &nb= sp;> >   * complete.
> >    > >   =  > >   */
> >    > >    = >
> >    > >    > Not sure what ha= ppened here, but this hunk belongs with
> >    > >  =  > tpm=5Fchip=5Funregister
> >    > > &nb= sp;  That's where it is. The context 'tpm1=5Fchip=5Funregister' the hunk
> >    shows
>= >    > >    is from the function 'above'.
= > >    >
> >    > Eh?
> >=    >
> >    > https://github.= com/stefanberger/linux/blob/
> >= ;    >
> >    63f0cd1bae930167d31bbe5d5779d= 40a277e91c5/drivers/char/tpm/tpm-chip.c#L311
> >
> > &nb= sp;  Sorry. Fixed here :
> >    https:/= /github.com/stefanberger/linux/commit/> 5808cd0b01b00e1a4e3b23d6970bac4efee69038
>
> Already ap= plied v4. Could you send a fix for this to the list?
> Thanks.=

I can post v5 that also has the Reviewed-by= 's applied.

https://github= .com/stefanberger/linux/commits/vtpm-driver.v5

<= font size=3D2>  Stefan


> =
> >       Stefan
>
> /Jarkko
> =

--=_alternative 0068F71F85257F6C_=-- --===============6849315132857821458== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------------ --===============6849315132857821458== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ tpmdd-devel mailing list tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/tpmdd-devel --===============6849315132857821458==--