From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Stefan Berger
<stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: ioctl API for vTPM driver
Date: Sun, 6 Mar 2016 14:05:37 +0200 [thread overview]
Message-ID: <20160306120537.GA22702@intel.com> (raw)
Hi
Some follow-up question that have popped up while I've started to
write a test program for this feature mainly about ioctl API. It's
better to be extremly cautious here because we will be stuck with this
ioctl forever.
1. Why the ioctl name is VTPM_NEW_DEV but the struct name is
vtpm_new_pair? It would be better if they both were either
VTPM_NEW_DEV and vtpm_new_dev or alternatively VTPM_NEW_PAIR
and vtpm_new_pair.
2. Is 'pair' or 'tuple' a better term?
3. Where is the documentation for the ioctl? I don't think I can
merge this to my next branch before it exists.
4. I have forgotten why the major and minor numbers were returned.
My guess is that they were returned so that a container could
replicate the device? This is one reason why documentation is
mandatory.
/Jarkko
------------------------------------------------------------------------------
next reply other threads:[~2016-03-06 12:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-06 12:05 Jarkko Sakkinen [this message]
[not found] ` <20160306120537.GA22702-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-03-06 12:11 ` ioctl API for vTPM driver Jarkko Sakkinen
[not found] ` <20160306121103.GA23480-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-03-06 12:28 ` Jarkko Sakkinen
[not found] ` <201603061621.u26GLsne030524@d01av01.pok.ibm.com>
[not found] ` <201603061621.u26GLsne030524-4ZtxiNBBw+3ImUpY6SP3GEEOCMrvLtNR@public.gmane.org>
2016-03-07 9:25 ` Jarkko Sakkinen
[not found] ` <20160306122816.GA24077-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-03-06 16:21 ` Stefan Berger
2016-03-07 0:40 ` Stefan Berger
[not found] ` <201603070040.u270eq7U019952-CUdSWdNILC7ImUpY6SP3GEEOCMrvLtNR@public.gmane.org>
2016-03-07 20:32 ` Jason Gunthorpe
[not found] ` <20160307203206.GA4303-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-03-07 21:12 ` Stefan Berger
[not found] ` <201603072115.u27LFcMK001519@d01av01.pok.ibm.com>
[not found] ` <201603072115.u27LFcMK001519-4ZtxiNBBw+3ImUpY6SP3GEEOCMrvLtNR@public.gmane.org>
2016-03-07 21:34 ` Jason Gunthorpe
[not found] ` <20160307213453.GA4630-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-03-07 22:24 ` Stefan Berger
[not found] ` <201603072224.u27MOBJO007812@d01av02.pok.ibm.com>
[not found] ` <201603072224.u27MOBJO007812-prK0F/7GlgzImUpY6SP3GEEOCMrvLtNR@public.gmane.org>
2016-03-07 22:40 ` Jason Gunthorpe
2016-03-08 17:24 ` Stefan Berger
[not found] ` <201603081724.u28HOrRB005375@d01av03.pok.ibm.com>
[not found] ` <201603081724.u28HOrRB005375-CUdSWdNILC7ImUpY6SP3GEEOCMrvLtNR@public.gmane.org>
2016-03-08 19:40 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160306120537.GA22702@intel.com \
--to=jarkko.sakkinen-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).