From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Stefan Berger <stefanb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: ioctl API for vTPM driver
Date: Mon, 7 Mar 2016 14:34:53 -0700 [thread overview]
Message-ID: <20160307213453.GA4630@obsidianresearch.com> (raw)
In-Reply-To: <201603072115.u27LFcMK001519-4ZtxiNBBw+3ImUpY6SP3GEEOCMrvLtNR@public.gmane.org>
On Mon, Mar 07, 2016 at 04:12:45PM -0500, Stefan Berger wrote:
> Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> wrote on 03/07/2016
> 03:32:06 PM:
> >
> > On Sun, Mar 06, 2016 at 07:40:40PM -0500, Stefan Berger wrote:
> >
> > > If you have suggestions or comments, let me know.
> > > I adjusted the code to reflect the ENOSYS (previously EINVAL) in
> case
> > > of unsupported flags or unsupported ioctls.
> >
> > Please don't use ENOSYS, the desire is that is only used by
> > systemcalls.
> Ok, found alternatives: ENOTSUPP for the flag ENOIOCTLCMD for the
> unsupported ioctl ?
ENOIOCTLCMD might be OK, just make sure it gets converted to ENOTTY:
390 * Is it an unrecognized ioctl? The correct returns are either
391 * ENOTTY (final) or ENOIOCTLCMD ("I don't know this one, try a
392 * fallback"). ENOIOCTLCMD gets turned into ENOTTY by the ioctl
393 * code before returning.
ENOTSUPP is for NFS internal use only, can't be exported to user
space.
Try EOPNOTSUPP
Jason
------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://makebettercode.com/inteldaal-eval
next prev parent reply other threads:[~2016-03-07 21:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-06 12:05 ioctl API for vTPM driver Jarkko Sakkinen
[not found] ` <20160306120537.GA22702-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-03-06 12:11 ` Jarkko Sakkinen
[not found] ` <20160306121103.GA23480-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-03-06 12:28 ` Jarkko Sakkinen
[not found] ` <201603061621.u26GLsne030524@d01av01.pok.ibm.com>
[not found] ` <201603061621.u26GLsne030524-4ZtxiNBBw+3ImUpY6SP3GEEOCMrvLtNR@public.gmane.org>
2016-03-07 9:25 ` Jarkko Sakkinen
[not found] ` <20160306122816.GA24077-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-03-06 16:21 ` Stefan Berger
2016-03-07 0:40 ` Stefan Berger
[not found] ` <201603070040.u270eq7U019952-CUdSWdNILC7ImUpY6SP3GEEOCMrvLtNR@public.gmane.org>
2016-03-07 20:32 ` Jason Gunthorpe
[not found] ` <20160307203206.GA4303-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-03-07 21:12 ` Stefan Berger
[not found] ` <201603072115.u27LFcMK001519@d01av01.pok.ibm.com>
[not found] ` <201603072115.u27LFcMK001519-4ZtxiNBBw+3ImUpY6SP3GEEOCMrvLtNR@public.gmane.org>
2016-03-07 21:34 ` Jason Gunthorpe [this message]
[not found] ` <20160307213453.GA4630-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-03-07 22:24 ` Stefan Berger
[not found] ` <201603072224.u27MOBJO007812@d01av02.pok.ibm.com>
[not found] ` <201603072224.u27MOBJO007812-prK0F/7GlgzImUpY6SP3GEEOCMrvLtNR@public.gmane.org>
2016-03-07 22:40 ` Jason Gunthorpe
2016-03-08 17:24 ` Stefan Berger
[not found] ` <201603081724.u28HOrRB005375@d01av03.pok.ibm.com>
[not found] ` <201603081724.u28HOrRB005375-CUdSWdNILC7ImUpY6SP3GEEOCMrvLtNR@public.gmane.org>
2016-03-08 19:40 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160307213453.GA4630@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=stefanb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).