From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Stefan Berger
<stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Cc: linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v6 08/11] tpm: Driver for supporting multiple emulated TPMs
Date: Fri, 11 Mar 2016 12:20:58 +0200 [thread overview]
Message-ID: <20160311102058.GB10270@intel.com> (raw)
In-Reply-To: <56E1AF9F.3010409-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
On Thu, Mar 10, 2016 at 12:32:15PM -0500, Stefan Berger wrote:
> On 03/10/2016 11:39 AM, Jarkko Sakkinen wrote:
> >+/* above flags */
> >+#define VTPM_FLAG_TPM2 1 /* emulator is TPM 2 */
> >+
> >+/* all supported flags */
> >+#define VTPM_FLAGS_ALL (VTPM_FLAG_TPM2)
> >+
> >+#define VTPM_TPM 0xa0
A better name would be VTPM_IOC_MAGIC. You should also update
Documentation/ioctl/ioctl-number.txt.
> >+
> >+#define VTPM_NEW_DEV _IOW(VTPM_TPM, 0x00, struct vtpm_new_dev)
> >I'd rather use VTPM_IOC_NEW_DEV.
>
> What about the name of the structure ? vtpm_ioc_new_dev?
If I look at other subsystems like drm the common practice is either
name the ioctl as VTPM_NEW_DEV_IOCTL or VTPM_IOC_NEW_DEV and not have
suffix or postfix in the parameter struct. I would just copy that
convention here.
> Stefan
/Jarkko
------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785111&iu=/4140
next prev parent reply other threads:[~2016-03-11 10:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 17:39 [PATCH v6 00/11] Multi-instance vTPM driver Stefan Berger
[not found] ` <1457545170-30120-1-git-send-email-stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-03-09 17:39 ` [PATCH v6 01/11] tpm: Get rid of chip->pdev Stefan Berger
2016-03-09 17:39 ` [PATCH v6 02/11] tpm: Get rid of devname Stefan Berger
2016-03-09 17:39 ` [PATCH v6 03/11] tpm: Provide strong locking for device removal Stefan Berger
2016-03-09 17:39 ` [PATCH v6 04/11] tpm: Get rid of module locking Stefan Berger
2016-03-09 17:39 ` [PATCH v6 05/11] tpm: Split out the devm stuff from tpmm_chip_alloc Stefan Berger
2016-03-09 17:39 ` [PATCH v6 06/11] tpm: Replace device number bitmap with IDR Stefan Berger
[not found] ` <1457545170-30120-7-git-send-email-stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-03-10 13:21 ` Jarkko Sakkinen
[not found] ` <20160310132156.GA16320-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-03-10 16:26 ` Stefan Berger
[not found] ` <201603101622.u2AGMCv3031274@d01av05.pok.ibm.com>
[not found] ` <201603101622.u2AGMCv3031274-8DuMPbUlb4HImUpY6SP3GEEOCMrvLtNR@public.gmane.org>
2016-03-10 16:40 ` Jarkko Sakkinen
2016-03-09 17:39 ` [PATCH v6 07/11] tpm: Introduce TPM_CHIP_FLAG_VIRTUAL Stefan Berger
2016-03-09 17:39 ` [PATCH v6 08/11] tpm: Driver for supporting multiple emulated TPMs Stefan Berger
2016-03-10 14:15 ` Jarkko Sakkinen
[not found] ` <1457545170-30120-9-git-send-email-stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-03-09 18:01 ` Andy Lutomirski
[not found] ` <CALCETrXDfHRdFnqK15o1yD8106sn4e6Susr9j7=GGi4sb-p0qQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-09 18:44 ` Stefan Berger
2016-03-10 16:39 ` Jarkko Sakkinen
[not found] ` <20160310163915.GA4863-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-03-10 17:30 ` Stefan Berger
2016-03-11 9:50 ` Jarkko Sakkinen
2016-03-10 17:32 ` Stefan Berger
[not found] ` <56E1AF9F.3010409-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-03-11 10:20 ` Jarkko Sakkinen [this message]
2016-03-10 22:12 ` Jason Gunthorpe
2016-03-09 17:39 ` [PATCH v6 09/11] tpm: Initialize TPM and get durations and timeouts Stefan Berger
2016-03-09 17:39 ` [PATCH v6 10/11] tpm: Add documentation for the tpm_vtpm device driver Stefan Berger
2016-03-09 17:39 ` [PATCH v6 11/11] A test program for vTPM device creation Stefan Berger
[not found] ` <1457545170-30120-12-git-send-email-stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-03-10 20:57 ` [PATCH v6 11/11] A test program for vTPM devicecreation Stefan Berger
[not found] ` <201603102058.u2AKw7Ie013400@d01av04.pok.ibm.com>
[not found] ` <201603102058.u2AKw7Ie013400-YREtIfBy6dDImUpY6SP3GEEOCMrvLtNR@public.gmane.org>
2016-03-11 10:30 ` Jarkko Sakkinen
[not found] ` <20160311103001.GA13368-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-03-11 13:16 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160311102058.GB10270@intel.com \
--to=jarkko.sakkinen-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).