From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH 05/12] tpm: Add tpm_set_vendordata and tpm_get_vendordata Date: Wed, 23 Mar 2016 10:48:45 -0600 Message-ID: <20160323164845.GD16336@obsidianresearch.com> References: <1458502483-16887-1-git-send-email-christophe-h.ricard@st.com> <1458502483-16887-6-git-send-email-christophe-h.ricard@st.com> <20160322062001.GB4058@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Christophe Ricard Cc: Jean-Luc BLANC , "ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org" , "tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , Christophe RICARD , Benoit HOUYERE List-Id: tpmdd-devel@lists.sourceforge.net On Wed, Mar 23, 2016 at 02:11:26PM +0100, Christophe Ricard wrote: > When working on the tpm_vendor_specific cleanup, i came also through > the conclusion that moving priv from tpm_vendor_specific to tpm_chip > structure would the most > simple and appropriate solution in short term. Someday, but we really should just use chip->dev drvdata for 'priv' > ...priv field may be renamed data... > Do you see anything against a serie removing atmel_get_priv and > tpm_nsc_get_priv and with a common helper replacing TPM_VPRIV ? These functions include a cast, they can't be generic. Jason ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140