From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH 5/5] tpm: Rename tpm_vendor_specific structure to tpm_protocol_infos Date: Wed, 23 Mar 2016 16:54:54 -0600 Message-ID: <20160323225454.GD17397@obsidianresearch.com> References: <1458764240-24185-1-git-send-email-christophe-h.ricard@st.com> <1458764240-24185-6-git-send-email-christophe-h.ricard@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1458764240-24185-6-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Christophe Ricard Cc: jean-luc.blanc-qxv4g6HH51o@public.gmane.org, ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, christophe-h.ricard-qxv4g6HH51o@public.gmane.org, benoit.houyere-qxv4g6HH51o@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Wed, Mar 23, 2016 at 09:17:20PM +0100, Christophe Ricard wrote: > As no more information available in tpm_vendor_specific structure are > available in tpm_vendor_specific structure rename it tpm_protocol_infos. Just get rid of it. Either the info rightly belongs in the chip or it should be pushed to a priv. Either way, we don't need this structure. > if (tpm_info->irq) { > tpm_tis_probe_irq_single(chip, intmask, IRQF_SHARED, > tpm_info->irq); > - if (!chip->vendor.irq) > + if (!chip->irq) > dev_err(&chip->dev, FW_BUG > "TPM interrupt not working, polling instead\n"); Read your diffs, these doesn't belong in this patch. Jason ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140