From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH 1/3] tpm/st33zp24/i2c: Drop two useless checks in ACPI probe path Date: Thu, 24 Mar 2016 15:23:31 +0200 Message-ID: <20160324132331.GB8452@intel.com> References: <1458719734-13752-1-git-send-email-christophe-h.ricard@st.com> <1458719734-13752-2-git-send-email-christophe-h.ricard@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1458719734-13752-2-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Christophe Ricard Cc: jean-luc.blanc-qxv4g6HH51o@public.gmane.org, ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, christophe-h.ricard-qxv4g6HH51o@public.gmane.org, benoit.houyere-qxv4g6HH51o@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Wed, Mar 23, 2016 at 08:55:32AM +0100, Christophe Ricard wrote: > When st33zp24_i2c_acpi_request_resources() gets called we > already know that the entries in ->acpi_match_table have matched ACPI ID > of the device. > In addition I2C client pointer cannot be NULL in any case (otherwise I2C > core would not call ->probe() for the driver in the first place). > > Drop the two useless checks from the driver. > > Signed-off-by: Christophe Ricard Reviewed-by: Jarkko Sakkinen /Jarkko > --- > drivers/char/tpm/st33zp24/i2c.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/drivers/char/tpm/st33zp24/i2c.c b/drivers/char/tpm/st33zp24/i2c.c > index f179aad..f8e8123 100644 > --- a/drivers/char/tpm/st33zp24/i2c.c > +++ b/drivers/char/tpm/st33zp24/i2c.c > @@ -113,19 +113,8 @@ static const struct st33zp24_phy_ops i2c_phy_ops = { > static int st33zp24_i2c_acpi_request_resources(struct i2c_client *client) > { > struct st33zp24_i2c_phy *phy = i2c_get_clientdata(client); > - const struct acpi_device_id *id; > struct gpio_desc *gpiod_lpcpd; > - struct device *dev; > - > - if (!client) > - return -EINVAL; > - > - dev = &client->dev; > - > - /* Match the struct device against a given list of ACPI IDs */ > - id = acpi_match_device(dev->driver->acpi_match_table, dev); > - if (!id) > - return -ENODEV; > + struct device *dev = &client->dev; > > /* Get LPCPD GPIO from ACPI */ > gpiod_lpcpd = devm_gpiod_get_index(dev, "TPM IO LPCPD", 1, > -- > 2.5.0 > ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140