From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Christophe Ricard
<christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: jean-luc.blanc-qxv4g6HH51o@public.gmane.org,
ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org,
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
christophe-h.ricard-qxv4g6HH51o@public.gmane.org,
benoit.houyere-qxv4g6HH51o@public.gmane.org
Subject: Re: [PATCH] tpm: drop int_queue from tpm_vendor_specific
Date: Thu, 24 Mar 2016 15:25:32 +0200 [thread overview]
Message-ID: <20160324132532.GE8452@intel.com> (raw)
In-Reply-To: <56F31170.4020702-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Wed, Mar 23, 2016 at 10:58:08PM +0100, Christophe Ricard wrote:
> On Tue, Mar 22, 2016 at 06:20:09AM +0200, Jarkko Sakkinen wrote:
> >Drop field int_queue from tpm_vendor_specific as it is used only by
> >tpm_tis. Probably all of the fields should be eventually dropped and
> >moved to the private structures of different drivers but it is better to
> >do this one step at a time in order not to break anything.
> >
> >Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@...>
>
> Don't you think read_queue could be dropped instead and merge with int_queue.
> I think they are both used for the same purpose and don't really see a mean to keep 2 queue.
>
> What do you think ?
Both should be dropped from tpm_vendor_specific.
> Best Regards
> Christophe
/Jarkko
------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140
next prev parent reply other threads:[~2016-03-24 13:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 7:55 [PATCH 0/3] Few st33zp24 fixes Christophe Ricard
[not found] ` <1458719734-13752-1-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-03-23 7:55 ` [PATCH 1/3] tpm/st33zp24/i2c: Drop two useless checks in ACPI probe path Christophe Ricard
[not found] ` <1458719734-13752-2-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-03-24 13:23 ` Jarkko Sakkinen
2016-03-23 7:55 ` [PATCH 2/3] tpm/st33zp24/spi: " Christophe Ricard
[not found] ` <1458719734-13752-3-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-03-24 13:24 ` Jarkko Sakkinen
2016-03-23 7:55 ` [PATCH 3/3] tpm/st33zp24: Remove unneeded tpm_reg in get_burstcount Christophe Ricard
[not found] ` <1458719734-13752-4-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-03-24 13:24 ` Jarkko Sakkinen
2016-03-23 8:17 ` [PATCH 0/3] Few st33zp24 fixes Jarkko Sakkinen
[not found] ` <20160323081755.GA6434-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-03-23 8:21 ` Christophe Ricard
[not found] ` <56F251F2.6050709-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-03-23 11:21 ` Jarkko Sakkinen
2016-03-23 21:58 ` [PATCH] tpm: drop int_queue from tpm_vendor_specific Christophe Ricard
[not found] ` <56F31170.4020702-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-03-24 13:25 ` Jarkko Sakkinen [this message]
2016-03-29 16:20 ` [PATCH 0/3] Few st33zp24 fixes Jarkko Sakkinen
-- strict thread matches above, loose matches on Subject: below --
2016-03-22 4:20 [PATCH] tpm: drop int_queue from tpm_vendor_specific Jarkko Sakkinen
[not found] ` <1458620409-15603-1-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-03-22 16:31 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160324132532.GE8452@intel.com \
--to=jarkko.sakkinen-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org \
--cc=benoit.houyere-qxv4g6HH51o@public.gmane.org \
--cc=christophe-h.ricard-qxv4g6HH51o@public.gmane.org \
--cc=christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jean-luc.blanc-qxv4g6HH51o@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).