From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH v2 4/7] tpm/tpm_i2c_atmel: Few code style fixes Date: Tue, 29 Mar 2016 17:17:44 +0300 Message-ID: <20160329141744.GC12764@intel.com> References: <1458975615-8095-1-git-send-email-christophe-h.ricard@st.com> <1458975615-8095-5-git-send-email-christophe-h.ricard@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1458975615-8095-5-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Christophe Ricard Cc: jean-luc.blanc-qxv4g6HH51o@public.gmane.org, ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, christophe-h.ricard-qxv4g6HH51o@public.gmane.org, benoit.houyere-qxv4g6HH51o@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Sat, Mar 26, 2016 at 08:00:12AM +0100, Christophe Ricard wrote: > Few code style fixes. Sorry but I don't care to apply this patch as there is much more This just adds noise and brings almost no benefit. /Jarkko > Signed-off-by: Christophe Ricard > --- > drivers/char/tpm/tpm_i2c_atmel.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/tpm/tpm_i2c_atmel.c b/drivers/char/tpm/tpm_i2c_atmel.c > index 5426c9d..d357065 100644 > --- a/drivers/char/tpm/tpm_i2c_atmel.c > +++ b/drivers/char/tpm/tpm_i2c_atmel.c > @@ -125,8 +125,7 @@ static u8 i2c_atmel_read_status(struct tpm_chip *chip) > /* Once the TPM has completed the command the command remains readable > * until another command is issued. */ > rc = i2c_master_recv(client, priv->buffer, sizeof(priv->buffer)); > - dev_dbg(&chip->dev, > - "%s: sts=%d", __func__, rc); > + dev_dbg(&chip->dev, "%s: sts=%d", __func__, rc); > if (rc <= 0) > return 0; > > @@ -192,6 +191,7 @@ static int i2c_atmel_probe(struct i2c_client *client, > static int i2c_atmel_remove(struct i2c_client *client) > { > struct tpm_chip *chip = i2c_get_clientdata(client); > + > tpm_chip_unregister(chip); > return 0; > } > -- > 2.5.0 > ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140