Re: [PATCH 2/5] tpm: drop list from struct tpm_vendor_specific

[Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>]

On Thu, Mar 24, 2016 at 04:08:35PM +0200, Jarkko Sakkinen wrote:
> On Wed, Mar 23, 2016 at 09:17:17PM +0100, Christophe Ricard wrote:
> > Dropped list from struct tpm_vendor_specific as it is not used in any
> > place.
> > 
> > It is initialized in tpm_i2c_infineon but not used at all in the code.
> > 
> > Signed-off-by: Christophe Ricard <christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
> 
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

You can drop this patch from next version of the series as it is
applied.

/Jarkko

> /Jarkko
> 
> > ---
> >  drivers/char/tpm/tpm.h              | 1 -
> >  drivers/char/tpm/tpm_i2c_infineon.c | 1 -
> >  2 files changed, 2 deletions(-)
> > 
> > diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h
> > index 0d1b7e6..357ac14 100644
> > --- a/drivers/char/tpm/tpm.h
> > +++ b/drivers/char/tpm/tpm.h
> > @@ -133,7 +133,6 @@ struct tpm_chip;
> >  struct tpm_vendor_specific {
> >  	int irq;
> >  
> > -	struct list_head list;
> >  	int locality;
> >  	unsigned long timeout_a, timeout_b, timeout_c, timeout_d; /* jiffies */
> >  	bool timeout_adjusted;
> > diff --git a/drivers/char/tpm/tpm_i2c_infineon.c b/drivers/char/tpm/tpm_i2c_infineon.c
> > index f2aa99e..e74f1c1 100644
> > --- a/drivers/char/tpm/tpm_i2c_infineon.c
> > +++ b/drivers/char/tpm/tpm_i2c_infineon.c
> > @@ -619,7 +619,6 @@ static int tpm_tis_i2c_init(struct device *dev)
> >  
> >  	dev_info(dev, "1.2 TPM (device-id 0x%X)\n", vendor >> 16);
> >  
> > -	INIT_LIST_HEAD(&chip->vendor.list);
> >  	tpm_dev.chip = chip;
> >  
> >  	tpm_get_timeouts(chip);
> > -- 
> > 2.5.0
> > 

------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140