Re: [PATCH 04/10] tpm: Manage itpm workaround with tis specific data_expect bit

[Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>]

On Sun, Apr 10, 2016 at 11:23:00PM +0200, Christophe Ricard wrote:
>  	itpm = true;
> +	priv->phy_ops->data_expect_mask = 0;
> +	priv->phy_ops->data_expect_val = 0;

> +static struct tpm_tis_phy_ops tis_phy_ops = {
> +	.data_expect_mask = TPM_STS_DATA_EXPECT,
> +	.data_expect_val = TPM_STS_DATA_EXPECT,
> +};
> +
>  static int tpm_mem_read_bytes(struct tpm_chip *chip, u32 addr, u16 len,
>  			      u8 *result)
>  {
> @@ -844,6 +864,7 @@ static int tpm_tis_init(struct device *dev, struct tpm_info *tpm_info,
>  	chip->timeout_b = TIS_TIMEOUT_B_MAX;
>  	chip->timeout_c = TIS_TIMEOUT_C_MAX;
>  	chip->timeout_d = TIS_TIMEOUT_D_MAX;
> +	priv->phy_ops = &tis_phy_ops;

That writes to a global static, for all probes. Don't do that.

Why is something called 'ops' having variant data? Just stick it in priv.

Jason

------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial! http://pubads.g.doubleclick.net/
gampad/clk?id=1444514301&iu=/ca-pub-7940484522588532